Move utils from const_eval to mir_transform#93502
Closed
lilasta wants to merge 1 commit intorust-lang:masterfrom
lilasta:move_files
Closed
Move utils from const_eval to mir_transform#93502lilasta wants to merge 1 commit intorust-lang:masterfrom lilasta:move_files
lilasta wants to merge 1 commit intorust-lang:masterfrom
lilasta:move_files
Conversation
rustbot
added
the
T-compiler
Contributor
|
r? @lcnr (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #93956) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
these functions don't really fit into any crate 😅 i guess moving them to transform is fine r=me after the rebase |
Contributor
Author
|
The latest changes made it difficult to move them cleanly, so I'll close this, sorry... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since most of these are only used in mir_transform.