[rustdoc-json] Make enum tuple variants match tuple structs

[CraftSpider]

No more free-floating struct_field members without references
Fixes #92945

[rust-highfive]

rustdoc-json-types is a public (although nightly-only) API. Consider changing src/librustdoc/json/conversions.rs instead; otherwise, make sure you update format_version.

cc @CraftSpider,@aDotInTheVoid

[rust-highfive]

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

[Mark-Simulacrum]

r? rust-lang/rustdoc

[petrochenkov]

@CraftSpider
Meta: could you prefix the PR names with the code area that it touches, like "rustdoc: Make enum tuple variants match tuple structs".
Without that the PR name looks like some nonsensical language change that affects how tuple variants behave in match expressions.

[CraftSpider]

Whoops, sorry. Relevant prefix added

[aDotInTheVoid]

Could you add a test for this?

[CraftSpider]

I'll update the enum tuple variant test to check that the struct_field IDs are in the child item list, is that good? The existence of the fields and such is already tested.

[bors]

☔ The latest upstream changes (presumably #94009) made this pull request unmergeable. Please resolve the merge conflicts.

[CraftSpider]

I'll fix this as soon as I have some free time, and update the FORMAT_VERSION

[JohnCSimon]

assigning back to author
@rustbot label: +S-waiting-on-author -S-waiting-on-review

[Dylan-DPC]

@CraftSpider any updates on this?

[bors]

☔ The latest upstream changes (presumably #97654) made this pull request unmergeable. Please resolve the merge conflicts.

[JohnCSimon]

@CraftSpider
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive