fix error handling for pthread_sigmask(3)#93530
Merged
bors merged 2 commits intorust-lang:masterfrom Apr 18, 2022
Merged
Conversation
Errors from pthread_sigmask(3) were handled using cvt(), which expects a return value of -1 on error and uses errno. However, pthread_sigmask(3) returns 0 on success and an error number otherwise. Fix it by replacing cvt() with cvt_nz().
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
JohnCSimon
added
S-waiting-on-author
JohnCSimon
added
S-waiting-on-author
JohnTitor
approved these changes
Apr 15, 2022
Member
|
Good catch, thanks! |
Collaborator
|
📌 Commit c492355 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
💡 This pull request was already approved, no need to approve it again.
|
Collaborator
|
📌 Commit c492355 has been approved by |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Apr 15, 2022
…nytm fix error handling for pthread_sigmask(3) Errors from `pthread_sigmask(3)` were handled using `cvt()`, which expects a return value of `-1` on error and uses `errno`. However, `pthread_sigmask(3)` returns `0` on success and an error number otherwise. Fix it by replacing `cvt()` with `cvt_nz()`.
Member
|
Failed in #96075 (comment) |
bors
added
S-waiting-on-author
Member
|
@anonion0 Could you move these imports under cfgs? |
rustbot
added
the
T-libs
Contributor
Author
|
Should be fixed now. |
Member
|
Thanks! |
Collaborator
|
📌 Commit e6aafbc has been approved by |
bors
removed
the
S-waiting-on-author
bors
added
the
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 17, 2022
…nTitor fix error handling for pthread_sigmask(3) Errors from `pthread_sigmask(3)` were handled using `cvt()`, which expects a return value of `-1` on error and uses `errno`. However, `pthread_sigmask(3)` returns `0` on success and an error number otherwise. Fix it by replacing `cvt()` with `cvt_nz()`.
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (e27d9df): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors from
pthread_sigmask(3)were handled usingcvt(), which expects a return value of-1on error and useserrno.However,
pthread_sigmask(3)returns0on success and an error number otherwise.Fix it by replacing
cvt()withcvt_nz().