Update browser-ui-test version#93597
Merged
bors merged 2 commits intorust-lang:masterfrom Feb 5, 2022
Merged
Conversation
GuillaumeGomez
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 1dbdfc4 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 3, 2022
…st, r=jsha Update browser-ui-test version The puppeteer version update is limited because new versions has some "interesting" flaws. r? `@jsha`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 3, 2022
…st, r=jsha Update browser-ui-test version The puppeteer version update is limited because new versions has some "interesting" flaws. r? ``@jsha``
Member
|
Hmmh, I think this might be responsible for this rollup failure / rustdoc test failure: |
bors
added
S-waiting-on-author
Member
Author
|
@matthiaskrgr I doesn't seem related. We can keep it out of rollups if you prefer though. @bors: r=jsha |
Collaborator
|
📌 Commit 1dbdfc4 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 3, 2022
…st, r=jsha Update browser-ui-test version The puppeteer version update is limited because new versions has some "interesting" flaws. r? `@jsha`
Member
|
@bors rollup=never another rollup attempt failed, let's see |
Contributor
|
@bors r- This PR is definitely the cause of the errors, it fails when rebased: |
bors
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
update-browser-ui-test
branch
from
1dbdfc4 to
1433b95
Compare
GuillaumeGomez
force-pushed
the
update-browser-ui-test
branch
from
010619b to
ef00e3b
Compare
Member
Author
|
I updated a comment in a GUI test to ensure ahead of time that the test isn't failing before r+ing again. |
Member
Author
|
Seems like GUI tests passed so let's go! @bors: r+ |
Collaborator
|
📌 Commit ef00e3b has been approved by |
bors
added
S-waiting-on-bors
Member
Author
|
Arf forgot... @bors: r=jsha |
Collaborator
|
💡 This pull request was already approved, no need to approve it again.
|
Collaborator
|
📌 Commit ef00e3b has been approved by |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (291bf94): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The puppeteer version update is limited because new versions has some "interesting" flaws.
r? @jsha