Conversation
bjorn3
added
A-driver
rustbot
added
the
T-rustdoc
Contributor
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
simplifications3
branch
from
c313e51 to
3f2c8f9
Compare
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
simplifications3
branch
from
3f2c8f9 to
5d54a45
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
r=me with fulldeps tests updated. |
bjorn3
force-pushed
the
simplifications3
branch
from
5d54a45 to
6a8430a
Compare
Collaborator
|
☔ The latest upstream changes (presumably #93956) made this pull request unmergeable. Please resolve the merge conflicts. |
1. It captured stdout and not stderr 2. It isn't used anywhere 3. All error messages should go to the DiagnosticOutput instead 4. It modifies thread local state
bjorn3
force-pushed
the
simplifications3
branch
from
6a8430a to
5eeff3f
Compare
Member
Author
|
@bors r=cjgillot |
Collaborator
|
📌 Commit 5eeff3f has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (902e590): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Member
Author
|
This seems to be a slight improvement of up to 0.5% across the board. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marking as blocked as it will conflict a bit with #93936.