Classify BinaryHeap & LinkedList unit tests as such#94126
Merged
bors merged 1 commit intorust-lang:masterfrom May 2, 2022
ssomers:alloc_prep_1
Merged
Classify BinaryHeap & LinkedList unit tests as such#94126bors merged 1 commit intorust-lang:masterfrom ssomers:alloc_prep_1
bors merged 1 commit intorust-lang:masterfrom
ssomers:alloc_prep_1
Conversation
Contributor
|
r? @yaahc (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #94824) made this pull request unmergeable. Please resolve the merge conflicts. |
yaahc
added
the
T-libs
JohnCSimon
added
S-waiting-on-review
Member
|
I'm reassigning this PR because I'm taking a break from the review rotation for a little while. Thank you for your patience. r? rust-lang/libs |
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit a3a5d83 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit a3a5d83 with merge 70d22763c74ed679957e72e1f36e0e60941977be... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
@bors retry waiting for selector search-settings timed out rustdoc-gui |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#94126 (Classify BinaryHeap & LinkedList unit tests as such) - rust-lang#96222 (Clarify docs for `from_raw_parts` on `Vec` and `String`) - rust-lang#96499 (Make it possible to write doctests for bootstrap) - rust-lang#96567 (Fix docs for u32 and i32 logs func) - rust-lang#96568 (std::fmt: Various fixes and improvements to documentation) - rust-lang#96571 (Add a bathroom stall to weird expressions test) - rust-lang#96610 (Update browser-ui-test version to 0.9.0) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All but one of these so-called integration test case are unit tests, just like btree's were (#75531). In addition, reunite the unit tests of linked_list that were split off during #23104 because they needed to remain unit tests (they were later moved to the separate file they are in during #63207). The two sets could remain separate files, but I opted to merge them back together, more or less in the order they used to be, apart from one duplicate name
test_split_offand one duplicate tiny functionlist_from.