s/compiler-flags/compile-flags in compiletest

[compiler-errors]

Also make compiletest panic so this doesn't happen in the future! I literally always forget which it's called, so I wanted to make my life easier in the future.

Also open to the possibility of parsing both.

[rust-highfive]

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

[Mark-Simulacrum]

Hm, I definitely think the validation is a good thing. I'm wondering if we should get stricter about what's present in test headers that looks like it might be a directive (but didn't get parsed as one) -- it's probably pretty rare that unintentionally users write things that look akin to directives?

Would you be up for adjusting compiletest to lint against unparsed name/value directives, at least? Those seem like the easiest to catch.

Eventually we might want to consider moving them to some kind of Rust-like #![compiletest::foo = ...] syntax which is probably not too hard to parse in compiletest and is much easier to lint on. cc #87396 on that thought, I guess.

[compiler-errors]

@Mark-Simulacrum, sure, denying // name: value you mean? If so, can do

[Mark-Simulacrum]

Yeah, essentially -- my hope is that there's not too many false positives (maybe we can ignore some specific names to avoid common false positives if needed).

[compiler-errors]

I can try this.

@rustbot author

[JohnCSimon]

@compiler-errors
Ping from triage: Can you please post the status of this PR?
Thank you.

[compiler-errors]

Ah, yeah, have kinda ignored this. I will work on it this week!

[compiler-errors]

Hm, probably won't get around to fixing this in the general case. @Mark-Simulacrum, can we merge this as-is? Otherwise I'll just close this.

@rustbot ready

[Mark-Simulacrum]

I'm fine with merging as-is.

@bors r+

[bors]

📌 Commit 52dd0b6 has been approved by Mark-Simulacrum

[bors]

⌛ Testing commit 52dd0b6 with merge 24f73cee380c44349067b397bb0b2c74508f71b4...

[Dylan-DPC]

@bors retry (included in rollup)

[bors]

⌛ Testing commit 52dd0b6 with merge d12b857...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing d12b857 to master...

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[rust-timer]

This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.