Bump bootstrap to 1.60 by Mark-Simulacrum · Pull Request #94290 · rust-lang/rust

Mark-Simulacrum · 2022-02-23T13:13:13Z

This bumps the bootstrap compiler to 1.60 and cleans up cfgs and Span's rustc_pass_by_value (enabled by the bootstrap bump).

rust-highfive · 2022-02-23T13:13:16Z

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

Some changes occurred in src/tools/rustfmt.

cc @calebcartwright

rust-highfive · 2022-02-23T13:13:17Z

@Mark-Simulacrum: no appropriate reviewer found, use r? to override

Mark-Simulacrum · 2022-02-23T13:13:31Z

r? @pietroalbini (but anyone can feel free to steal)

library/core/src/panicking.rs

emilyalbini · 2022-02-23T17:34:28Z

r=me

Mark-Simulacrum · 2022-02-23T17:55:06Z

@bors r=pietroalbini rollup=never

bors · 2022-02-23T17:55:08Z

📌 Commit bdbe0a60b036a2779e981f6a665f7e7c1cfe7ce4 has been approved by pietroalbini

bors · 2022-02-24T16:41:23Z

⌛ Testing commit bdbe0a60b036a2779e981f6a665f7e7c1cfe7ce4 with merge e94a89f16b721e5906a0cd627e61d9cd264a1cca...

bors · 2022-02-24T16:44:46Z

💔 Test failed - checks-actions

mati865 · 2022-02-24T16:45:46Z

CI error:

warning: spurious network error (1 tries remaining): failed to get 200 response from `[https://crates.io/api/v1/crates/libc/0.2.116/download`,](https://crates.io/api/v1/crates/libc/0.2.116/download%60,) got 502

c410-f3r · 2022-02-24T16:50:33Z

crates.io is having some problems

Mark-Simulacrum · 2022-02-24T17:23:02Z

@bors retry

Mark-Simulacrum · 2022-02-24T22:38:02Z

@bors r=pietroalbini

bors · 2022-02-24T22:38:03Z

📌 Commit 27d61eabf3f25b8b2324e9d550bd11b01f126889 has been approved by pietroalbini

Mark-Simulacrum · 2022-02-24T22:59:27Z

@bors r=pietroalbini

bors · 2022-02-24T22:59:28Z

📌 Commit bcf6f1c625b4311b17d8fb235172d52a938fad8b has been approved by pietroalbini

nbdd0121 · 2022-02-24T23:00:52Z

library/core/src/panicking.rs

It's okay to call this in regular Rust code, it's just that it doesn't really make much sense.

Mark-Simulacrum · 2022-02-24T23:04:41Z

@bors r=pietroalbini

bors · 2022-02-24T23:04:42Z

📌 Commit 566f9ded078b0b2e4d629a6bfa9dc9b753fb440a has been approved by pietroalbini

bors · 2022-02-25T03:58:49Z

☔ The latest upstream changes (presumably #93368) made this pull request unmergeable. Please resolve the merge conflicts.

This function was updated in a recent PR (92911) to be called without the caller information passed in, but the function signature itself was not altered with cfg_attr at the time.

Mark-Simulacrum · 2022-02-25T13:43:15Z

@bors r=pietroalbini -- rebased

bors · 2022-02-25T13:43:16Z

📌 Commit 3c62f2f has been approved by pietroalbini

bors · 2022-02-25T18:34:06Z

⌛ Testing commit 3c62f2f with merge d981633...

bors · 2022-02-25T20:53:42Z

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing d981633 to master...

rust-timer · 2022-02-25T23:04:50Z

Finished benchmarking commit (d981633): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 23, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 23, 2022

rust-highfive assigned emilyalbini Feb 23, 2022

This comment has been minimized.

Sign in to view

Mark-Simulacrum force-pushed the bump-bootstrap branch from d9bd5a5 to bdbe0a6 Compare February 23, 2022 13:57

bjorn3 reviewed Feb 23, 2022

View reviewed changes

library/core/src/panicking.rs Outdated Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2022

Urgau mentioned this pull request Feb 23, 2022

Enable conditional compilation checking on the Rust codebase #94298

Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 24, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2022

This comment has been minimized.

Sign in to view

Mark-Simulacrum mentioned this pull request Feb 24, 2022

track_caller on panic_no_unwind leads to LLVM crash #94337

Closed

Mark-Simulacrum force-pushed the bump-bootstrap branch from bdbe0a6 to 27d61ea Compare February 24, 2022 22:37

Mark-Simulacrum force-pushed the bump-bootstrap branch from 27d61ea to bcf6f1c Compare February 24, 2022 22:59

nbdd0121 reviewed Feb 24, 2022

View reviewed changes

library/core/src/panicking.rs Outdated

Copy link

Member

nbdd0121 Feb 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to call this in regular Rust code, it's just that it doesn't really make much sense.

Mark-Simulacrum force-pushed the bump-bootstrap branch from bcf6f1c to 566f9de Compare February 24, 2022 23:04

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 25, 2022

c410-f3r mentioned this pull request Feb 25, 2022

Update Clippy #94329

Merged

Mark-Simulacrum added 4 commits February 25, 2022 08:00

Bump bootstrap to 1.60

ea65f50

Switch bootstrap cfgs

22c3a71

Enable rustc_pass_by_value for Span

76b13c9

Re-add track_caller to panic_no_unwind in bootstrap

3c62f2f

This function was updated in a recent PR (92911) to be called without the caller information passed in, but the function signature itself was not altered with cfg_attr at the time.

Mark-Simulacrum force-pushed the bump-bootstrap branch from 566f9de to 3c62f2f Compare February 25, 2022 13:01

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 25, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 25, 2022

bors merged commit d981633 into rust-lang:master Feb 25, 2022

rustbot added this to the 1.61.0 milestone Feb 25, 2022

Uh oh!

Conversation

Mark-Simulacrum commented Feb 23, 2022

Uh oh!

rust-highfive commented Feb 23, 2022

Uh oh!

rust-highfive commented Feb 23, 2022

Uh oh!

Mark-Simulacrum commented Feb 23, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

emilyalbini commented Feb 23, 2022

Uh oh!

Mark-Simulacrum commented Feb 23, 2022

Uh oh!

bors commented Feb 23, 2022

Uh oh!

bors commented Feb 24, 2022

Uh oh!

bors commented Feb 24, 2022

Uh oh!

mati865 commented Feb 24, 2022

Uh oh!

c410-f3r commented Feb 24, 2022

Uh oh!

Mark-Simulacrum commented Feb 24, 2022

Uh oh!

This comment has been minimized.

Mark-Simulacrum commented Feb 24, 2022

Uh oh!

bors commented Feb 24, 2022

Uh oh!

Mark-Simulacrum commented Feb 24, 2022

Uh oh!

bors commented Feb 24, 2022

Uh oh!

nbdd0121 Feb 24, 2022

Choose a reason for hiding this comment

Uh oh!

Mark-Simulacrum commented Feb 24, 2022

Uh oh!

bors commented Feb 24, 2022

Uh oh!

bors commented Feb 25, 2022

Uh oh!

Mark-Simulacrum commented Feb 25, 2022

Uh oh!

bors commented Feb 25, 2022

Uh oh!

bors commented Feb 25, 2022

Uh oh!

bors commented Feb 25, 2022

Uh oh!

rust-timer commented Feb 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants