cleanup: remove unused ability to have LLVM null-terminate const strings#94638
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 7, 2022
Merged
cleanup: remove unused ability to have LLVM null-terminate const strings#94638bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
T-compiler
Contributor
|
Some changes occured to rustc_codegen_gcc cc @antoyo |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
The |
nagisa
reviewed
Mar 5, 2022
nagisa
approved these changes
Mar 5, 2022
nagisa
added
S-waiting-on-author
erikdesjardins
force-pushed
the
noextranull
branch
from
fc6b4c2 to
e1a4bf6
Compare
Contributor
|
@bors r=nagisa |
Collaborator
|
📌 Commit e1a4bf6 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (3d1eaf4): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
bjorn3
pushed a commit
to bjorn3/rust
that referenced
this pull request
Mar 26, 2022
cleanup: remove unused ability to have LLVM null-terminate const strings (and the copied function in rustc_codegen_gcc) Noticed this while writing rust-lang#94450 (comment). r? `@nagisa`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(and the copied function in rustc_codegen_gcc)
Noticed this while writing #94450 (comment).
r? @nagisa