Closed
Conversation
Testing leading `.` and `..` components were missing from the unix tests.
Add Result::{ok, err, and, or, unwrap_or} as const
Already opened tracking issue rust-lang#92384.
I don't think that this should actually cause any issues as long as the constness is unstable, but we may want to double-check that this doesn't get interpreted as a weird `Drop` bound even for non-const usages.
doc: `Iterator::partition` use partial type hints Switch to partial type hints to indicate only the collection type is needed.
…-Simulacrum rustbuild: support RelWithDebInfo for lld r? `@alexcrichton` LLVM has flags that control the level of debuginfo generated when building via rustbuild. Since LLD is built separately, it currently has no way of generating any debuginfo. This change re-uses the same flags as LLVM for LLD to ensure it has the same level of debuginfo generated as LLVM.
…lan-DPC Unix path::absolute: Fix leading "." component Testing leading `.` and `..` components were missing from the unix tests. This PR adds them and fixes the leading `.` case. It also fixes the test cases so that they do an exact comparison. This problem reported by `@axetroy`
Member
Author
|
@bors r+ rollup=never p=4 |
Collaborator
|
📌 Commit e12fba5 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit e12fba5 with merge ea6f99db068baf4f0819d5b42ccbd3f880bb0b97... |
Member
bors
added
S-waiting-on-author
Member
|
@bors retry r- |
bors
added
S-waiting-on-bors
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Iterator::partitionuse partial type hints #92509 (doc:Iterator::partitionuse partial type hints)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup