BTree: let method clear recycle root memory#94800
Closed
ssomers wants to merge 1 commit intorust-lang:masterfrom
ssomers:btree_clever_clear
Closed
BTree: let method clear recycle root memory#94800ssomers wants to merge 1 commit intorust-lang:masterfrom ssomers:btree_clever_clear
ssomers wants to merge 1 commit intorust-lang:masterfrom
ssomers:btree_clever_clear
Conversation
Contributor
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
kennytm
added
the
T-libs
Collaborator
|
☔ The latest upstream changes (presumably #92962) made this pull request unmergeable. Please resolve the merge conflicts. |
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #98103) made this pull request unmergeable. Please resolve the merge conflicts. |
Collaborator
|
☔ The latest upstream changes (presumably #98178) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BTree's
clearmethods up to now literally drops and starts anew. HashMap's clear "keeps the allocated memory for reuse.". This PR tries the simplest way to preserve the maximum of memory. If a map/set has multiple nodes,cleardoesn't recycle the original root node but the last one in the tree, which is the last leaf node that was deallocated up to now and which would most likely have been the same memory allocated once you add elements to the cleared map.This is a regression for those wanting to deallocate as much memory as possible. They could use
my_map = BTreeMap::new()instead. Is there a regression in normal drop or into_iter? I have no idea.Also, now two key-value pairs are allowed to panic-on-drop and unwinding continues, an abort only happens on the third pair panicking. This can be remedied, but I assumed it's acceptable behaviour.