Merged
Conversation
…some parts of rustc_passes break before the `&&` Update compiler/rustc_passes/src/check_const.rs Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
…-remove-unnecessary-nesting-in-rustc-passes, r=lcnr Refactor: use `format-args-capture` and remove unnecessary nested if blocks in some parts of `rust_passes`
Return err instead of ICE Having `escaping_bound_vars` results in ICE when trying to create `ty::Binder::dummy`, to avoid it we return err like the line above. I think this requires a more sophisticated fix, I would love to investigate if mentorship is available 🤓 Fixes rust-lang#95023 and rust-lang#85350
Add needs-* directives to many tests These are necessary to ignore tests that need features unsupported by cg_clif.
…imation, r=jsha Remove animation on source sidebar Fixes rust-lang#95043. Didn't upload a demo considering how simple it is to test in a browser. :) r? ``@jsha``
…k, r=petrochenkov Update the unstable book with the new `values()` form of check-cfg Forgot to update the unstable book in rust-lang#94362 r? ``@petrochenkov``
…e, r=Dylan-DPC move `adt_const_params` to its own tracking issue the new tracking issue is rust-lang#95174 r? ``@rust-lang/project-const-generics``
rustbot
added
T-compiler
Member
Author
|
@bors r+ rollup=never p=6 |
Collaborator
|
📌 Commit 44200a9 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Mar 21, 2022
Collaborator
|
Finished benchmarking commit (3c17c84): comparison url. Summary: This benchmark run did not return any relevant results. 1 results were found to be statistically significant but too small to be relevant. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
format-args-captureand remove unnecessary nested if blocks in some parts ofrust_passes#95074 (Refactor: useformat-args-captureand remove unnecessary nested if blocks in some parts ofrust_passes)values()form of check-cfg #95166 (Update the unstable book with the newvalues()form of check-cfg)adt_const_paramsto its own tracking issue #95175 (moveadt_const_paramsto its own tracking issue)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup