Skip to content

[PERF] Revert "Rollup merge of #95512"#95811

Closed
rylev wants to merge 1 commit intorust-lang:masterfrom
rylev:revert-95512
Closed

[PERF] Revert "Rollup merge of #95512"#95811
rylev wants to merge 1 commit intorust-lang:masterfrom
rylev:revert-95512

Conversation

@rylev
Copy link
Member

@rylev rylev commented Apr 8, 2022

This reverts commit d473024 (#95512) so we can do a perf run on it.

Context: perf regression

r? @ghost

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 8, 2022
@rylev
Copy link
Member Author

rylev commented Apr 8, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

rust-timer commented Apr 8, 2022

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 8, 2022
@bors
Copy link
Collaborator

bors commented Apr 8, 2022

⌛ Trying commit d6208b535afc17750d20191dd80122488c5187fc with merge 3eb49290885e2e9f66b1fddcb483df17da5d251d...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rylev
Revert "Rollup merge of rust-lang#95512 - davidtwco:diagnostic-transl…
82fbecd 
…ation, r=oli-obk"

This reverts commit d473024, reversing
changes made to 73eab35.
@bors
Copy link
Collaborator

bors commented Apr 9, 2022

☔ The latest upstream changes (presumably #95840) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 9, 2022
@rylev
Copy link
Member Author

rylev commented Apr 11, 2022

Closing for now. Reverting such a large PR that changes so much code is hard. This PR should not have been rolled up in the first place.

@rylev rylev closed this Apr 11, 2022
@rylev rylev deleted the revert-95512 branch April 11, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-perf Status: Waiting on a perf run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rylev @rust-timer @bors @rust-log-analyzer @rustbot