Experiment: Apply #[deprecated_safe] to env::set_var/env::remove_var#95942
Conversation
… unsafety checkers)
rustbot
added
the
T-compiler
|
Some changes occured to rustc_codegen_cranelift cc @bjorn3 Some changes occured to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
|
r? @lcnr (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ghost
mentioned this pull request
|
will be away next week, so if it gets ready for review by that time, feel free to reassign this, will needs |
lcnr
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #96087) made this pull request unmergeable. Please resolve the merge conflicts. |
| signal_handler::install(); | ||
| let mut callbacks = TimePassesCallbacks::default(); | ||
| install_ice_hook(); | ||
| // SAFETY: in main(), no other threads could be reading or writing the environment |
There was a problem hiding this comment.
// SAFETY: Lack of thread conflicts asserted by the caller
| assert!(x("screen") == "/usr/share/terminfo/s/screen"); | ||
| assert!(get_dbpath_for_term("") == None); | ||
| // FIXME(skippy) there's no fix for deprecated_safe until tests can be run single threaded | ||
| #[cfg_attr(not(bootstrap), allow(deprecated_safe))] |
There was a problem hiding this comment.
This style of cfg_attrs is suspicious - aren't the bootstrap cfgs going to be deleted at the next upgrade?
Instead, use // SAFETY: FIXME(skippy) This code is incorrect.
|
Aside: |
8 participants
cc #94978
cc #95025
cc #94619