Rollup of 5 pull requests

[Dylan-DPC]

Successful merges:

• Update books #96032 (Update books)
• Reword clarification on lifetime for ptr->ref safety docs #96136 (Reword clarification on lifetime for ptr->ref safety docs)
• Fix snapshot --bless not working anymore in htmldocck #96143 (Fix snapshot --bless not working anymore in htmldocck)
• Use revisions instead of nll compare mode for /self/ ui tests #96148 (Use revisions instead of nll compare mode for /self/ ui tests)
• Replace u8to64_le macro with u64::from_le_bytes #96156 (Replace u8to64_le macro with u64::from_le_bytes)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[Dylan-DPC]

@bors r+ rollup=never p=5

[bors]

📌 Commit 55e3997 has been approved by Dylan-DPC

[bors]

⌛ Testing commit 55e3997 with merge 8305398...

[bors]

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 8305398 to master...

[rust-timer]

Finished benchmarking commit (8305398): comparison url.

Summary:

• Primary benchmarks: 😿 relevant regression found
• Secondary benchmarks: no relevant changes found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count1	1	0	0	0	1
mean2	2.5%	N/A	N/A	N/A	2.5%
max	2.5%	N/A	N/A	N/A	2.5%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Footnotes

1. number of relevant changes ↩

2. the arithmetic mean of the percent change ↩

[pnkfelix]

visiting for weekly performance triage.

this regressed syn-1.0.89 opt full by 2.5%.

The only PR on the list in this rollup that I could imagine having any effect at all on performance is PR #96156. I tried to skim over the control-flow for the resulting method calls; they look like they are at least all marked with #[inline]; do some need an #[inline(always)] ?

In any case, looking at the graph for syn-1.0.89-opt:

it looks to me like the real problem here is that our measurements started getting more noisy somewhere around 2022-04-17. I do not see this PR as being at fault in any significant way when I look at it in that context.

@rustbot label: +perf-regression-triaged

[pnkfelix]

Oh, and I did look at the cachegrind output for syn-1.0.89-opt; posted here: https://gist.github.com/4d10eb49892af0df7249014707d86cdc

it looks to me like this regression is peanut-butter smeared all over llvm backend work. (Which I think is at least consistent with a hypothesis that this is due to replacing the macro-defn with a procedure.)