Merged
Conversation
…e of other errors
do not suggest when trait_ref is some Update compiler/rustc_resolve/src/late/diagnostics.rs Co-authored-by: lcnr <rust@lcnr.de> use helper struct add a test for functions with some params refactor debug log
Update `int_roundings` methods from feedback This updates `#![feature(int_roundings)]` (rust-lang#88581) from feedback. All methods now take `NonZeroX`. The documentation makes clear that they panic in debug mode and wrap in release mode. r? `@joshtriplett` `@rustbot` label +T-libs +T-libs-api +S-waiting-on-review
…oc, r=m-ou-se Improve Rc::new_cyclic and Arc::new_cyclic documentation Fixes rust-lang#95672. cc `@CAD97` (since I used your explanations)
…function, r=lcnr Suggest calling `Self::associated_function()` closes rust-lang#96453
…triddle Use "strict" mode in JS scripts Part of rust-lang#93058. r? `@notriddle`
…rochenkov Report that opaque types are not allowed in impls even in the presence of other errors fixes rust-lang#96569 before this PR those useful errors were hidden because either `unused parameter` or `only traits defined in the current crate can be implemented for arbitrary types` got emitted first.
…r=petrochenkov Show invisible delimeters (within comments) when pretty printing. Because invisible syntax is really hard to work with! r? `@petrochenkov`
interpret/validity: debug-check ScalarPair layout information This would have caught rust-lang#96158. I ran the Miri test suite and it still passes. r? `@oli-obk`
Member
Author
|
@bors r+ rollup=never p=7 |
Collaborator
|
📌 Commit 6804819 has been approved by |
Collaborator
|
⌛ Testing commit 6804819 with merge 8a53faa59e2022e9b3829e49f7f5b35aaaeaa61c... |
Collaborator
|
💔 Test failed - checks-actions |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced May 5, 2022
Closed
Collaborator
|
Finished benchmarking commit (50cf76c): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
int_roundingsmethods from feedback #95359 (Updateint_roundingsmethods from feedback)Self::associated_function()#96507 (Suggest callingSelf::associated_function())Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup