Skip to content

[beta] Clippy backport ICE/infinite loop fix#96740

Closed
flip1995 wants to merge 2 commits intorust-lang:betafrom
flip1995:clippy_backport
Closed

[beta] Clippy backport ICE/infinite loop fix#96740
flip1995 wants to merge 2 commits intorust-lang:betafrom
flip1995:clippy_backport

Conversation

@flip1995
Copy link
Member

@flip1995 flip1995 commented May 5, 2022

Those commits are picked from the latest Clippy sync: #96735

This fixed the issue rust-lang/rust-clippy#8689

flip1995 added 2 commits May 5, 2022 17:46
@flip1995
Prevent infinite (exponential) recursion in only_used_in_recursion
b9035c4 
This simplifies the visitor code a bit and prevents checking expressions
multiple times. I still think this lint should be removed for now,
because its code isn't really tested.
@flip1995
Move only_used_in_recursion to nursery
53074f5
@rust-highfive
Copy link
Contributor

rust-highfive commented May 5, 2022

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

@rust-highfive
Copy link
Contributor

rust-highfive commented May 5, 2022

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

rust-highfive commented May 5, 2022

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 5, 2022
@flip1995 flip1995 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 6, 2022
@flip1995
Copy link
Member Author

flip1995 commented May 12, 2022

ping @Mark-Simulacrum We'd like to get this in before beta branching tomorrow.

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented May 12, 2022

The backport needs to be approved by either the clippy team or the compiler team.

Note that Friday is next beta branching, and that doesn't affect backport schedules, so while it's important to get this accepted or not quickly we're not on a rush to do so until beta branch on Friday.

@flip1995
Copy link
Member Author

flip1995 commented May 12, 2022

@rust-lang/clippy This backport moves the only_used_in_recursion lint to nursery and prevents it from running, if not explicitly enabled. I want to backport this infinite loop / ICE fix, because the lint is not really tested well enough and I have the suspicion that we'll see more of those infinite loops with this lint like it currently exists in beta. This infinite loop happens on long method chains and since builder patterns are popular in Rust, we can expect that this will happen often.

This still misses an approval of a Clippy team member and because I don't want to self-approve this, could someone else from the team take another look, please?

@Mark-Simulacrum Mark-Simulacrum added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels May 13, 2022
@Mark-Simulacrum Mark-Simulacrum added this to the 1.61.0 milestone May 13, 2022
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented May 13, 2022

Unilaterally approving for backport as we're somewhat pressed for time.

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 13, 2022
Merged
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented May 13, 2022

Bundled into #97014.

bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2022
@bors
Auto merge of rust-lang#97014 - Mark-Simulacrum:beta-next, r=Mark-Sim…
eb1e588 
…ulacrum

[beta] backports

This backports/rolls up:

*  Quick fix for rust-lang#96223. rust-lang#96679
*  [beta] Revert rust-lang#92519 on beta rust-lang#96556
*  [beta] Clippy backport ICE/infinite loop fix rust-lang#96740
*  Revert "Prefer projection candidates instead of param_env candidates for Sized predicates" rust-lang#96593
@fmease fmease added the T-clippy Relevant to the Clippy team. label Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team.

Projects

None yet

Milestone

1.61.0

Development

Successfully merging this pull request may close these issues.

5 participants

@flip1995 @rust-highfive @Mark-Simulacrum @GuillaumeGomez @fmease