simplify_type improvements and cursed docs#97024
Conversation
f83cc93 to
6ebef2b
Compare
|
I feel like edit: after talking to @BoxyUwU, |
b21e83d to
ff823ee
Compare
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
There was a problem hiding this comment.
ah yes, I am equally to blame :) it's really just universal (placeholders) vs existential (infer)
|
@bors r+ |
|
📌 Commit db19e2b has been approved by |
|
☀️ Test successful - checks-actions |
|
oh, we've used the |
|
Gah. rust-lang/homu#47 is the issue for this, we'll need to back this out from master I think, I'm not sure whether a force push dropping it is the best idea. |
|
Finished benchmarking commit (c067287): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
|
To follow up on the merge -- we manually ran CI on the merged commit, which thankfully passed. See https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/try-based.20merge.20into.20master for some discussion. |
the existing
TreatParamsenum pretty much mixes everything up. Not sure why this looked right to me in #94057This also includes two changes which impact perf:
ty::Projectionwith inference vars shouldn't be treated as a rigid type, even if fully normalizedty::Placeholderonly unifies with itself, so actually returnSomefor themr? @nikomatsakis