Disallow compare-mode=nll test differences#97272
Merged
bors merged 1 commit intorust-lang:masterfrom May 24, 2022
Merged
Conversation
d924d6a to
2c75eca
Compare
Member
Author
|
@Mark-Simulacrum this is ready for review :) |
Member
|
@bors r+ rollup=iffy |
Collaborator
|
📌 Commit 2c75eca has been approved by |
Collaborator
|
⌛ Testing commit 2c75eca with merge 7668bedeea66c6b840f92309fc439781a3e38cdf... |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
Member
Author
|
@bors retry seems unrelated |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (b8d0cd8): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that new tests don't get added not as revisions if they have nll output. This will make stabilization PR easier.
r? @Mark-Simulacrum