[RFC 2011] Basic compiler infrastructure#97450
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 2, 2022
Merged
Conversation
rustbot
added
the
T-compiler
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
oli-obk
requested changes
Jun 2, 2022
Contributor
oli-obk
left a comment
oli-obk
left a comment
There was a problem hiding this comment.
Thanks for splitting this up. As a next smaller step, maybe just add binary operations and nothing else?
src/test/ui/rfc-2011-nicer-assert-messages/feature-gate-generic_assert.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
Done. Thank you for the review Sure! Next step binary operations will be. |
oli-obk
approved these changes
Jun 2, 2022
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit aa115eb has been approved by |
bors
added
S-waiting-on-bors
Contributor
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 2, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#97420 (Be a little nicer with casts when formatting `fn` pointers) - rust-lang#97450 ([RFC 2011] Basic compiler infrastructure) - rust-lang#97599 (Fix JSON reexport ICE) - rust-lang#97617 (Rustdoc anonymous reexports) - rust-lang#97636 (Revert rust-lang#96682.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting #96496 into smaller pieces as was done in #97233. Hope review will be easier.
This PR practically contains no logic and only serves as a building ground for the actual code that will be placed in a posterior step.
context.rsto place the newassert!logic. Has a lot of unused elements but all of them are used by the implementation.symidentifiers that are mostly based on the library elements -> https://github.com/rust-lang/rust/blob/master/library/core/src/asserting.rsassert.rsto branch tocontext.rsif the unstable flag is enabled.