[RFC 2011] Minimal initial implementation by c410-f3r · Pull Request #97665 · rust-lang/rust

c410-f3r · 2022-06-02T19:41:08Z

Tracking issue: #44838
Third step of #96496

Implementation has ~290 LOC with the bare minimum to be in a functional state. Currently only searches for binary operations to mimic what assert_eq! and assert_ne! already do.

r? @oli-obk

src/test/ui/rfc-2011-nicer-assert-messages/codegen.stdout

eddyb · 2022-06-03T03:33:44Z

Can the PR description be updated with links to the RFC and/or tracking issue? (Ideally the title should also be representative, but that's not as big of a deal)

c410-f3r · 2022-06-03T10:44:55Z

Can the PR description be updated with links to the RFC and/or tracking issue? (Ideally the title should also be representative, but that's not as big of a deal)

Done

oli-obk · 2022-06-03T13:47:06Z

I won't get to this before 2022-06-13 (in 10 days).

c410-f3r · 2022-06-03T13:49:56Z

I won't get to this before 2022-06-13 (in 10 days).

No worries, take your time. Thanks

compiler/rustc_builtin_macros/src/assert/context.rs

c410-f3r · 2022-06-13T14:08:02Z

@oli-obk

Thank you for the review. I tried to address as many concerns as possible.

oli-obk · 2022-06-13T14:35:04Z

@bors r+

bors · 2022-06-13T14:35:07Z

📌 Commit 1c2c236 has been approved by oli-obk

[RFC 2011] Minimal initial implementation Tracking issue: rust-lang#44838 Third step of rust-lang#96496 Implementation has ~290 LOC with the bare minimum to be in a functional state. Currently only searches for binary operations to mimic what `assert_eq!` and `assert_ne!` already do. r? `@oli-obk`

[RFC 2011] Minimal initial implementation Tracking issue: rust-lang#44838 Third step of rust-lang#96496 Implementation has ~290 LOC with the bare minimum to be in a functional state. Currently only searches for binary operations to mimic what `assert_eq!` and `assert_ne!` already do. r? ``@oli-obk``

Dylan-DPC · 2022-06-14T08:34:04Z

failed in rollup

Dylan-DPC · 2022-06-14T08:34:10Z

@bors r-

Dylan-DPC · 2022-06-15T10:46:09Z

@bors r=oli-obk

bors · 2022-06-15T10:46:10Z

📌 Commit 605c64a has been approved by oli-obk

bors · 2022-06-15T13:45:33Z

⌛ Testing commit 605c64a with merge 021f781df9f25e2a55fe359d1872a991e8b58b8a...

bors · 2022-06-15T14:21:23Z

💔 Test failed - checks-actions

rust-log-analyzer · 2022-06-15T14:25:09Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

.......... (60/64)
....       (64/64)


/checkout/src/test/rustdoc-gui/toggle-docs.goml An exception occured: socket hang up
== STACKTRACE ==
Error
    at innerRunTestCode (/node-v14.4.0-linux-x64/lib/node_modules/browser-ui-test/src/index.js:533:16)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

c410-f3r · 2022-06-15T14:31:57Z

/checkout/src/test/rustdoc-gui/toggle-docs.goml An exception occured: socket hang up

WTF... Probably not related

Dylan-DPC · 2022-06-15T15:01:22Z

yep it's spurious

@bors retry

c410-f3r · 2022-06-15T15:04:30Z

Thanks

bors · 2022-06-15T17:43:04Z

⌛ Testing commit 605c64a with merge ca98305...

bors · 2022-06-15T20:28:33Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing ca98305 to master...

rust-timer · 2022-06-15T21:45:37Z

Finished benchmarking commit (ca98305): comparison url.

Instruction count

Primary benchmarks: no relevant changes found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	0.9%	0.9%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-0.3%	-0.3%	1
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

Primary benchmarks: mixed results
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	0.8%	0.9%	2
Regressions 😿 (secondary)	2.2%	3.1%	4
Improvements 🎉 (primary)	-5.2%	-5.2%	1
Improvements 🎉 (secondary)	-3.5%	-4.3%	2
All 😿🎉 (primary)	-1.2%	-5.2%	3

Cycles

Results

Primary benchmarks: 🎉 relevant improvement found
Secondary benchmarks: no relevant changes found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-2.2%	-2.2%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-2.2%	-2.2%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

[RFC 2011] Expand expressions where possible Tracking issue: rust-lang#44838 Fourth step of rust-lang#96496 Extends rust-lang#97665 considering expressions that are good candidates for expansion. r? `@oli-obk`

oli-obk · 2022-06-21T08:49:19Z

Checked the one regression locally with cachegrind, and it turns out it's actually an improvement, so that's just some perf noise

rust-highfive assigned oli-obk Jun 2, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 2, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2022

c410-f3r commented Jun 2, 2022

View reviewed changes

src/test/ui/rfc-2011-nicer-assert-messages/codegen.stdout Outdated Show resolved Hide resolved

c410-f3r closed this Jun 2, 2022

c410-f3r force-pushed the assert-compiler branch from f1fddba to 44e9516 Compare June 2, 2022 19:52

c410-f3r reopened this Jun 2, 2022

This comment has been minimized.

Sign in to view

c410-f3r force-pushed the assert-compiler branch from aa5329b to f3163a0 Compare June 2, 2022 20:11

c410-f3r changed the title ~~[RFC 2011] Initial implementation~~ [RFC 2011] Minimal initial implementation Jun 3, 2022

oli-obk requested changes Jun 13, 2022

View reviewed changes

c410-f3r force-pushed the assert-compiler branch from f3163a0 to 1c2c236 Compare June 13, 2022 14:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2022

Dylan-DPC mentioned this pull request Jun 13, 2022

Rollup of 5 pull requests #98058

Closed

Dylan-DPC mentioned this pull request Jun 14, 2022

Rollup of 5 pull requests #98088

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 15, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 15, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 15, 2022

bors merged commit ca98305 into rust-lang:master Jun 15, 2022

rustbot added this to the 1.63.0 milestone Jun 15, 2022

This was referenced Jun 15, 2022

Implement RFC-2011 (Nicer assert! messages) #96496

Closed

[RFC 2011] Expand expressions where possible #98148

Merged

sunfishcode mentioned this pull request Jul 7, 2022

Remove dependency on more-asserts bytecodealliance/wasmtime#4408

Merged

Dylan-DPC mentioned this pull request Aug 24, 2023

Tracking issue for RFC 2011: Generic assert #44838

Open

3 tasks

fmease added the F-generic_assert `#![feature(generic_assert)]` label Apr 8, 2024

matthiaskrgr mentioned this pull request Apr 20, 2024

ICE: expected principal trait object #124092

Closed

Uh oh!

Conversation

c410-f3r commented Jun 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

eddyb commented Jun 3, 2022

Uh oh!

c410-f3r commented Jun 3, 2022

Uh oh!

oli-obk commented Jun 3, 2022

Uh oh!

c410-f3r commented Jun 3, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

c410-f3r commented Jun 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oli-obk commented Jun 13, 2022

Uh oh!

bors commented Jun 13, 2022

Uh oh!

Dylan-DPC commented Jun 14, 2022

Uh oh!

Dylan-DPC commented Jun 14, 2022

Uh oh!

Dylan-DPC commented Jun 15, 2022

Uh oh!

bors commented Jun 15, 2022

Uh oh!

bors commented Jun 15, 2022

Uh oh!

bors commented Jun 15, 2022

Uh oh!

rust-log-analyzer commented Jun 15, 2022

Uh oh!

c410-f3r commented Jun 15, 2022

Uh oh!

Dylan-DPC commented Jun 15, 2022

Uh oh!

c410-f3r commented Jun 15, 2022

Uh oh!

bors commented Jun 15, 2022

Uh oh!

bors commented Jun 15, 2022

Uh oh!

rust-timer commented Jun 15, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

oli-obk commented Jun 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

c410-f3r commented Jun 2, 2022 •

edited

Loading

c410-f3r commented Jun 13, 2022 •

edited

Loading