Make {Mutex, Condvar, RwLock}::new() const.#97791
Merged
bors merged 2 commits intorust-lang:masterfrom Jun 19, 2022
Merged
Conversation
m-ou-se
added
T-libs-api
rust-highfive
added
the
S-waiting-on-review
Member
Author
|
@rfcbot merge |
|
Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
63 tasks
m-ou-se
added
S-waiting-on-fcp
rfcbot
added
the
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
removed
the
proposed-final-comment-period
rfcbot
added
finished-final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
Member
Author
|
@bors r+ |
Collaborator
|
📌 Commit edae495 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (15fc228): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
japaric
added a commit
to japaric/cargo-call-stack
that referenced
this pull request
Jun 22, 2022
rust-lang/rust#97791 appears to have broken -Z build-std (?)
This was referenced Jun 22, 2022
3 tasks
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2022
make Condvar, Mutex, RwLock const constructors work with the `unsupported` impl applying this patch locally to the `rust-src` component fixes rust-lang#98378 however, the solution seems wrong to me because PR rust-lang#97791 didn't add any `rustc_const_stable` attribute to underlying implementations like `std::sys::unix::futex`, so I must be missing something about how const-stability is checked ... maybe the `restricted_std` feature (gate?) has an effect? fixes rust-lang#98378 fixes rust-lang#98293 (probably)
|
It raised my eyebrows when static mutex just worked, that's how I found this page! Holy shit, great work! 💪 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 23, 2024
…lnay Make `Barrier::new()` const I guess this was just missed in rust-lang#97791? `@rustbot` label T-libs-api -T-libs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to have
static M: Mutex<_> = Mutex::new(..);🎉Our implementations on Linux, on Windows, and various BSDs and some tier 3 platforms have already been using a non-allocating const-constructible implementation. As of #97647, the remaining platforms (most notably macOS) now have a const-constructible implementation as well. This means we can finally make these functions publicly const.
Tracking issue: #93740