Leak pthread_{mutex,rwlock}_t if it's dropped while locked.

[m-ou-se]

Fixes #85434.

[rust-highfive]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[rust-highfive]

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

[m-ou-se]

r? @Amanieu

[Amanieu]

Does this issue also apply to pthread_rwlock_t? If so then we should apply the same workaround there.

[m-ou-se]

Attempting to destroy an uninitialized read-write lock results in undefined behavior.

Yes. Updating the PR. :)

[Amanieu]

@bors r+

[bors]

📌 Commit b4fe8f3 has been approved by Amanieu

[JohnTitor]

Failed in rollup: #98263 (comment)

error[E0425]: cannot find function `forget` in this scope
--> library/std/src/sys/unix/locks/pthread_rwlock.rs:27:13
|
27|             forget(rwlock);
| ^^^^^^not found in this scope
|
help: consider importing one of these items
|
1| use core::intrinsics::forget;
|
1| use core::mem::forget;
|
1| use crate::intrinsics::forget;
|
1| use crate::mem::forget;
|

Missing import on macOS.
@bors r-

[m-ou-se]

@bors r=Amanieu

[bors]

📌 Commit e642c59 has been approved by Amanieu