Skip to content

Document unstable --extern options#98226

Merged
bors merged 1 commit intorust-lang:masterfrom
ChrisDenton:doc-extern-options
Jun 22, 2022
Merged

Document unstable --extern options#98226
bors merged 1 commit intorust-lang:masterfrom
ChrisDenton:doc-extern-options

Conversation

@ChrisDenton
Copy link
Member

@ChrisDenton ChrisDenton commented Jun 18, 2022

These are needed for Cargo's build-std feature and for anyone who wanted to do a similar thing outside of Cargo.

@ChrisDenton
Copy link
Member Author

ChrisDenton commented Jun 18, 2022

cc @ehuss @jyn514

I'll admit I don't really know what I'm doing but hopefully this is a start.

jyn514
jyn514 reviewed Jun 18, 2022
View reviewed changes
@jyn514
Copy link
Member

jyn514 commented Jun 18, 2022

Looks like highfive got confused - I'll go ahead and

r? @ehuss

@jyn514 jyn514 added A-resolve Area: Name/path resolution done by `rustc_resolve` specifically A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Jun 18, 2022
@jyn514
Copy link
Member

jyn514 commented Jun 18, 2022

cc @petrochenkov

jyn514
jyn514 reviewed Jun 18, 2022
View reviewed changes
@jyn514 jyn514 mentioned this pull request Jun 18, 2022
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
ehuss
ehuss reviewed Jun 21, 2022
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a small addition. These really should have tracking issues, but I never got around to it.

@ChrisDenton
Copy link
Member Author

ChrisDenton commented Jun 22, 2022

I should probably squish all these commits if that's ok?

@ChrisDenton @jyn514 @ehuss
Document unstable --extern options
c20e0e1 
Co-Authored-By: Joshua Nelson <github@jyn.dev>
Co-Authored-By: Eric Huss <eric@huss.org>
@jyn514
Copy link
Member

jyn514 commented Jun 22, 2022

Yeah, I think it would be nice to squash :)

@ehuss
Copy link
Contributor

ehuss commented Jun 22, 2022

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 22, 2022

📌 Commit c20e0e1 has been approved by ehuss

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 22, 2022
@JohnTitor JohnTitor mentioned this pull request Jun 22, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 22, 2022
@bors
Auto merge of rust-lang#98375 - JohnTitor:rollup-e5c6rgo, r=JohnTitor
89a0783 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#95446 (update CPU usage script)
 - rust-lang#96768 (Use futex based thread parker on Fuchsia.)
 - rust-lang#97454 (Add release notes for 1.62)
 - rust-lang#97516 (clarify how Rust atomics correspond to C++ atomics)
 - rust-lang#97818 (Point at return expression for RPIT-related error)
 - rust-lang#97895 (Simplify `likely!` and `unlikely!` macro)
 - rust-lang#98005 (Add some tests for impossible bounds)
 - rust-lang#98226 (Document unstable `--extern` options)
 - rust-lang#98356 (Add missing period)
 - rust-lang#98363 (remove use of &Alloc in btree tests)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@petrochenkov
Copy link
Contributor

petrochenkov commented Jun 22, 2022

@ChrisDenton
Could you make a tracking issue for this stuff?
(And also link to the item (3) in #93901 (comment) from it.)

@ChrisDenton
Copy link
Member Author

ChrisDenton commented Jun 22, 2022

I could but I'd prefer to defer to @ehuss or someone else if they have the time. I don't really know the implementation details or history. But I can do a best effort attempt if it would help get the ball rolling.

@bors bors merged commit 3559718 into rust-lang:master Jun 22, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 22, 2022
@ChrisDenton ChrisDenton deleted the doc-extern-options branch June 22, 2022 10:50
@ehuss
Copy link
Contributor

ehuss commented Jun 22, 2022

I'll set up the tracking issues later today.

@ehuss
Copy link
Contributor

ehuss commented Jun 22, 2022

Posted #98401 to add links to the tracking issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehuss ehuss ehuss left review comments

+1 more reviewer

@jyn514 jyn514 jyn514 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ehuss ehuss

Labels

A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-resolve Area: Name/path resolution done by `rustc_resolve` specifically S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

7 participants

@ChrisDenton @jyn514 @rust-log-analyzer @ehuss @bors @petrochenkov @rustbot