Use CSS variables to handle theming#98460
Merged
bors merged 2 commits intorust-lang:masterfrom Jul 2, 2022
Merged
Conversation
GuillaumeGomez
added
T-rustdoc
Contributor
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
css-simplification
branch
from
76f2500 to
ece56a1
Compare
Member
Author
|
Forgot to remove some rules in |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
css-simplification
branch
from
ece56a1 to
23a5eee
Compare
Collaborator
|
☔ The latest upstream changes (presumably #98545) made this pull request unmergeable. Please resolve the merge conflicts. |
jsha
suggested changes
Jun 26, 2022
Contributor
jsha
left a comment
jsha
left a comment
There was a problem hiding this comment.
Generally looks good and I like the direction. Needs rebase.
GuillaumeGomez
force-pushed
the
css-simplification
branch
from
23a5eee to
7f6ce7d
Compare
Collaborator
|
A change occurred in the Ayu theme. cc @Cldfire |
Member
Author
|
Updated (also updated the demo). |
Member
Author
|
Since I applied all comments, let's move forward. @bors r=jsha rollup |
Member
Author
|
Second try? @bors r=jsha rollup |
Collaborator
|
📌 Commit 7f6ce7d has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 1, 2022
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#97249 (`<details>`/`<summary>` UI fixes) - rust-lang#98418 (Allow macOS to build LLVM as shared library) - rust-lang#98460 (Use CSS variables to handle theming) - rust-lang#98497 (Improve some inference diagnostics) - rust-lang#98708 (rustdoc: fix 98690 Panic if invalid path for -Z persist-doctests) Failed merges: - rust-lang#98761 (more `need_type_info` improvements) r? `@ghost` `@rustbot` modify labels: rollup
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 13, 2022
Use CSS variables to handle theming (part 2) Follow-up of rust-lang#98460. As usual, there shouldn't be any UI change. You can test it [here](https://rustdoc.crud.net/imperio/css-theme-var/bar/index.html). r? `@jsha`
This was referenced Sep 12, 2022
Merged
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 17, 2022
…, r=notriddle Continue migration of CSS themes Now that rust-lang#101898 has been merged, we can move forward. This PR moves more CSS theme rules as CSS variables. I also added a GUI test to prevent regressions. Part of rust-lang#98460. r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 17, 2022
…, r=notriddle Continue migration of CSS themes Now that rust-lang#101898 has been merged, we can move forward. This PR moves more CSS theme rules as CSS variables. I also added a GUI test to prevent regressions. Part of rust-lang#98460. r? ``@notriddle``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 1, 2022
…r=notriddle Migrate sidebar links color to CSS variables and unify themes with ayu Part of rust-lang#98460. This PR does two things: 1. Migrate more theme CSS rules toward CSS variables. 2. Remove `a.current` specific colors depending on the kind of the item behind the link. The `ayu` theme was already doing it this way and I think it makes much more sense like this. You can test it [here](https://rustdoc.crud.net/imperio/sidebar-links-color/lib2/struct.Foo.html) by hovering other module's items in the sidebar (or check the selector `a.current`). cc `@jsha` r? `@notriddle`
This was referenced Oct 1, 2022
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 3, 2022
… r=notriddle Migrate `.stab` elements style to CSS variables Part of rust-lang#98460. There should be no UI changes. r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 4, 2022
…earch-result, r=notriddle,jsha Migrate CSS theme for search results Part of rust-lang#98460. Just like rust-lang#102237, I unified theme to how the `ayu` handles this one: only one color for the background when search results are focused or hovered. You can test it [here](https://rustdoc.crud.net/imperio/migrate-css-theme-search-result/lib2/index.html?search=coo). cc `@jsha` r? `@notriddle` PS: The repetition in GUI tests is getting out of hand so I opened GuillaumeGomez/browser-UI-test#363 to think about adding possibility to declare functions so we can greatly improve this.
This was referenced Oct 4, 2022
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 6, 2022
… r=notriddle Migrate search input color to CSS variable Part of rust-lang#98460. No UI changes. r? `@notriddle`
This was referenced Oct 26, 2022
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 28, 2022
…notriddle Migrate source line numbers CSS to CSS variables Part of rust-lang#98460. No UI changes. r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 28, 2022
…notriddle Migrate source line numbers CSS to CSS variables Part of rust-lang#98460. No UI changes. r? ``@notriddle``
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the start for our simplification of theming. Considering how big the diff quickly becomes, I think it's better to do it in multiple parts.
Normally they shouldn't be any UI changes. You can check it here.
cc @notriddle
r? @jsha