Windows: Use `FindFirstFileW` for getting the metadata of locked system files by ChrisDenton · Pull Request #98916 · rust-lang/rust

ChrisDenton · 2022-07-05T08:19:32Z

Usually opening a file handle with access set to metadata only will always succeed, even if the file is locked. However some special system files, such as C:\hiberfil.sys, are locked by the system in a way that denies even that. So as a fallback we try reading the cached metadata from the directory.

Note that the test is a bit iffy. I don't know if hiberfil.sys actually exists in the CI.

r? rust-lang/libs

Usually opening a file handle with access set to metadata only will always succeed, even if the file is locked. However some special system files, such as `C:\hiberfil.sys`, are locked by the system in a way that denies even that. So as a fallback we try reading the cached metadata from the directory.

rustbot · 2022-07-05T08:19:35Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

library/std/src/fs/tests.rs

strega-nil-ms · 2022-07-08T17:44:41Z

This is, as far as I can tell, equivalent to the code in the Microsoft STL: https://github.com/microsoft/STL/blob/062002644137095c606f0a5a11d04f0278e8632e/stl/src/filesystem.cpp#L794

(and so is likely to be correct)

thomcc

Sorry it took so long to get to this. This looks good to me.

thomcc · 2022-07-17T20:38:14Z

@bors r+

bors · 2022-07-17T20:38:16Z

📌 Commit 5f5bcb3 has been approved by thomcc

It is now in the queue for this repository.

Windows: Use `FindFirstFileW` for getting the metadata of locked system files Fixes rust-lang#96980 Usually opening a file handle with access set to metadata only will always succeed, even if the file is locked. However some special system files, such as `C:\hiberfil.sys`, are locked by the system in a way that denies even that. So as a fallback we try reading the cached metadata from the directory. Note that the test is a bit iffy. I don't know if `hiberfil.sys` actually exists in the CI. r? rust-lang/libs

ChrisDenton · 2022-07-18T14:01:15Z

@bors r- failed in rollup

Oh, I was afraid of this. hiberfil.sys doesn't exist in CI. Hm, maybe we could keep the test but mark it as ignore? Admittedly it not running in CI very much limits its utility but at least it can be run locally.

thomcc · 2022-07-18T14:04:09Z

Oof, I thought about marking it as rollup=never for that reason (I guess doing a try run would have been more prudent...)

Marking the test as ignore makes sense to me.

The file it's testing does not exist in the CI environment.

thomcc · 2022-07-18T14:10:03Z

It seems a bit goofy to do a try run now that the test is ignored, so I'll just reapprove.

@bors r+

bors · 2022-07-18T14:10:04Z

📌 Commit eee8ca9 has been approved by thomcc

It is now in the queue for this repository.

Dylan-DPC · 2022-07-18T15:43:33Z

failed in rollup

@bors r-

ChrisDenton · 2022-07-18T16:45:27Z

Sorry, we already noticed that and addressed the issue.

@bors r=thomcc

bors · 2022-07-18T16:45:29Z

📌 Commit eee8ca9 has been approved by thomcc

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - rust-lang#98784 (Suggest returning local on "expected `ty`, found `()`" due to expr-less block) - rust-lang#98916 (Windows: Use `FindFirstFileW` for getting the metadata of locked system files) - rust-lang#99433 (Erase regions before comparing signatures of foreign fns.) - rust-lang#99452 (int_macros was only using to_xe_bytes_doc and not from_xe_bytes_doc) - rust-lang#99481 (Add regression test for rust-lang#71547) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

ChrisDenton added 2 commits July 5, 2022 07:53

impl From<c::WIN32_FIND_DATAW> for FileAttr

13ab796

rust-highfive assigned thomcc Jul 5, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 5, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 5, 2022

bjorn3 reviewed Jul 5, 2022

View reviewed changes

library/std/src/fs/tests.rs Outdated Show resolved Hide resolved

bjorn3 reviewed Jul 5, 2022

View reviewed changes

library/std/src/fs/tests.rs Show resolved Hide resolved

Add comment and simplify hiberfil_sys test

2d06504

ChrisDenton force-pushed the hiberfil.sys branch from 75355d7 to 2d06504 Compare July 5, 2022 11:06

Test if [try_]exists can find hiberfil.sys

5f5bcb3

thomcc reviewed Jul 17, 2022

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2022

Dylan-DPC mentioned this pull request Jul 18, 2022

Rollup of 5 pull requests #99400

Closed

Dylan-DPC mentioned this pull request Jul 18, 2022

Rollup of 5 pull requests #99407

Closed

Dylan-DPC mentioned this pull request Jul 18, 2022

Rollup of 5 pull requests #99412

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 18, 2022

Ignore hiberfil_sys test in CI

eee8ca9

The file it's testing does not exist in the CI environment.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 18, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2022

Dylan-DPC mentioned this pull request Jul 20, 2022

Rollup of 5 pull requests #99493

Merged

bors merged commit 8039567 into rust-lang:master Jul 20, 2022

rustbot added this to the 1.64.0 milestone Jul 20, 2022

Uh oh!

Conversation

ChrisDenton commented Jul 5, 2022

Uh oh!

rustbot commented Jul 5, 2022

Uh oh!

Uh oh!

Uh oh!

strega-nil-ms commented Jul 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thomcc left a comment

Choose a reason for hiding this comment

Uh oh!

thomcc commented Jul 17, 2022

Uh oh!

bors commented Jul 17, 2022

Uh oh!

ChrisDenton commented Jul 18, 2022

Uh oh!

thomcc commented Jul 18, 2022

Uh oh!

thomcc commented Jul 18, 2022

Uh oh!

bors commented Jul 18, 2022

Uh oh!

Dylan-DPC commented Jul 18, 2022

Uh oh!

ChrisDenton commented Jul 18, 2022

Uh oh!

bors commented Jul 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

strega-nil-ms commented Jul 8, 2022 •

edited

Loading