add BorrowedBuf::buf* accessor functions for getting the original buffer#98962
add BorrowedBuf::buf* accessor functions for getting the original buffer#98962programmerjake wants to merge 1 commit intorust-lang:masterfrom
BorrowedBuf::buf* accessor functions for getting the original buffer#98962Conversation
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
(rust-highfive has picked a reviewer for you, use r? to override) |
|
buf_mut looks unsound, as you can deinitialize bytes that are assume to be init.
|
020e8cb to
0d5bd5b
Compare
nice catch, i changed |
|
@rustbot label +T-libs-api -T-libs |
|
Hi, this is an API change and so needs to go through the ACP process, as described by the bot. Please open one if you haven't already, and link it here. @rustbot label -S-waiting-on-review +S-waiting-on-ACP |
|
ReadBuf::buf* accessor functions for getting the original bufferBorrowedBuf::buf* accessor functions for getting the original buffer
|
☔ The latest upstream changes (presumably #117736) made this pull request unmergeable. Please resolve the merge conflicts. |
dtolnay
left a comment
There was a problem hiding this comment.
Let's pick this up in rust-lang/libs-team#65, or a new ACP, if there is still a use case for this.
Thanks anyway for the PR!
I noticed these functions were missing so I had to use an annoying workaround...
ACP: rust-lang/libs-team#65 [accepted]