[PERF ONLY] Revert #97786

[lqd]

Tries to investigate the perf regression in rollup #98656 by reverting #97786.

r? @ghost

[lqd]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 7e81427 with merge b84f273a938608b554ad4ef2c48f9335816fdb79...

[bors]

☀️ Try build successful - checks-actions
Build commit: b84f273a938608b554ad4ef2c48f9335816fdb79 (b84f273a938608b554ad4ef2c48f9335816fdb79)

[rust-timer]

Queued b84f273a938608b554ad4ef2c48f9335816fdb79 with parent 5b8cf49, future comparison URL.

[rust-timer]

Finished benchmarking commit (b84f273a938608b554ad4ef2c48f9335816fdb79): comparison url.

Instruction count

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	1.5%	2.3%	8
Improvements 🎉 (primary)	-1.6%	-10.4%	123
Improvements 🎉 (secondary)	-3.1%	-10.4%	85
All 😿🎉 (primary)	-1.6%	-10.4%	123

Max RSS (memory usage)

Results

• Primary benchmarks: 🎉 relevant improvement found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.2%	3.2%	5
Improvements 🎉 (primary)	-1.0%	-1.0%	1
Improvements 🎉 (secondary)	-3.7%	-3.7%	1
All 😿🎉 (primary)	-1.0%	-1.0%	1

Cycles

Results

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: 🎉 relevant improvements found

	mean1	max	count2
Regressions 😿 (primary)	2.8%	2.8%	1
Regressions 😿 (secondary)	3.0%	3.0%	1
Improvements 🎉 (primary)	-3.4%	-7.5%	14
Improvements 🎉 (secondary)	-5.7%	-7.9%	24
All 😿🎉 (primary)	-3.0%	-7.5%	15

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[lqd]

Looks like it was.