Skip to content

Add test for #96797#99059

Merged
bors merged 1 commit intorust-lang:masterfrom
Amanieu:fix-96797
Jul 21, 2022
Merged

Add test for #96797#99059
bors merged 1 commit intorust-lang:masterfrom
Amanieu:fix-96797

Conversation

@Amanieu
Copy link
Member

@Amanieu Amanieu commented Jul 8, 2022

This was fixed in LLVM which was updated in #98285.

https://reviews.llvm.org/D127751

Fixes #96797

@rust-highfive
Copy link
Contributor

rust-highfive commented Jul 8, 2022

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 8, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 8, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Amanieu Amanieu force-pushed the fix-96797 branch 2 times, most recently from 682eeba to 5566099 Compare July 12, 2022 14:16
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jul 14, 2022

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Jul 14, 2022

📌 Commit 5566099 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 18, 2022
@Dylan-DPC
Rollup merge of rust-lang#99059 - Amanieu:fix-96797, r=Mark-Simulacrum
5e58b1b 
Add test for rust-lang#96797

This was fixed in LLVM which was updated in rust-lang#98285.

https://reviews.llvm.org/D127751

Fixes rust-lang#96797
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 18, 2022
Closed
@Dylan-DPC
Copy link
Member

Dylan-DPC commented Jul 18, 2022 •
edited
Loading

failed in rollup
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 18, 2022
@Amanieu
Copy link
Member Author

Amanieu commented Jul 18, 2022

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Jul 18, 2022

📌 Commit d301996f83a009a2087c20df0efc272f1d267dfb has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2022
@bors
Copy link
Collaborator

bors commented Jul 21, 2022

⌛ Testing commit d301996f83a009a2087c20df0efc272f1d267dfb with merge 211bee9657d533a6fb2ae605436f80137ed866a4...

@bors
Copy link
Collaborator

bors commented Jul 21, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 21, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Amanieu
Copy link
Member Author

Amanieu commented Jul 21, 2022

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Jul 21, 2022

📌 Commit 4423341 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2022
@bors
Copy link
Collaborator

bors commented Jul 21, 2022

⌛ Testing commit 4423341 with merge 1673f14...

@bors
Copy link
Collaborator

bors commented Jul 21, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 1673f14 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 21, 2022
@bors bors merged commit 1673f14 into rust-lang:master Jul 21, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 21, 2022
@rust-timer
Copy link
Collaborator

rust-timer commented Jul 21, 2022

Finished benchmarking commit (1673f14): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.1% 2.1% 2
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -5.9% -5.9% 2
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 2.5% 2.5% 1
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -2.0% -2.0% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 0.2% 2.5% 2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

Functions referenced by global_asm merged into other functions by LLVM

8 participants

@Amanieu @rust-highfive @rust-log-analyzer @Mark-Simulacrum @bors @Dylan-DPC @rust-timer @rustbot