Add label for generic arg (+ APIT) and RPIT callables in label_fn_like#99131
Merged
bors merged 2 commits intorust-lang:masterfrom Jul 15, 2022
Merged
Add label for generic arg (+ APIT) and RPIT callables in label_fn_like#99131bors merged 2 commits intorust-lang:masterfrom
label_fn_like#99131bors merged 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
T-compiler
Contributor
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
compiler-errors
changed the title
label_fn_likelabel_fn_like
cjgillot
reviewed
Jul 11, 2022
Contributor
cjgillot
left a comment
cjgillot
left a comment
There was a problem hiding this comment.
Thanks @compiler-errors. This looks good. I left a few questions.
Contributor
There was a problem hiding this comment.
Should we print something here? Point to where the impl for s comes from?
Contributor
Author
There was a problem hiding this comment.
It's a bit of work to do so, but done!
cjgillot
added
S-waiting-on-author
compiler-errors
force-pushed
the
label-fn
branch
from
74e755c to
e0d1fca
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
cjgillot
approved these changes
Jul 13, 2022
Contributor
cjgillot
left a comment
cjgillot
left a comment
There was a problem hiding this comment.
r=me with an extra comment.
Collaborator
|
☔ The latest upstream changes (presumably #99231) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
label-fn
branch
from
e0d1fca to
d25abdc
Compare
Contributor
Author
|
@bors r=cjgillot |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 15, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#99113 (Simplify [a]rc code a little) - rust-lang#99131 (Add label for generic arg (+ APIT) and RPIT callables in `label_fn_like`) - rust-lang#99237 (removed unused CSS and unused HTML IDs) - rust-lang#99239 (Add myself to the set of people notified when MIR changes.) - rust-lang#99241 (Remove comment referring to constness.rs) - rust-lang#99257 (Add regression test for rust-lang#89436) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Member
|
This is amazing, thank you so much!! |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 22, 2022
…ler-errors Fix `ClosureKind::to_def_id` `Fn` and `FnOnce` were mixed up in rust-lang#99131.
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Nov 22, 2022
…ler-errors Fix `ClosureKind::to_def_id` `Fn` and `FnOnce` were mixed up in rust-lang#99131.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 22, 2022
…ler-errors Fix `ClosureKind::to_def_id` `Fn` and `FnOnce` were mixed up in rust-lang#99131.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98308