Fix bad suggestions when initializing enum as struct

[danobi]

Fix bad suggestions by adding a new heuristic where we assume correct
intent when there's an exact match on an in-scope identifier.

[rust-highfive]

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

[estebank]

I'm not entirely sure this is the right heuristic we should be using here. A better approach would be to check what kind of literal is being tried to be used (struct/tuple/unit?) and see if the field names/count/types match, in order to determine whether we've found an "exact" match. I'm looking at some of the changes and instead of suggesting importing the right Foo, we only emit a suggestion for Foos, which isn't really the best suggestion we can give there.

[bors]

☔ The latest upstream changes (presumably #100708) made this pull request unmergeable. Please resolve the merge conflicts.

[estebank]

@danobi would you have time to try and address the comments?

[danobi]

Hi @estebank , been a bit busy with a move recently. I hope to find some time to revisit this soon. But if anyone wants to take this PR and fix it up, please feel free.

[estebank]

@danobi, no rush.

[JohnCSimon]

Ping from triage:
@danobi What is the status of this PR?

[JohnCSimon]

@danobi
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you do please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive