Rollup of 11 pull requests

[matthiaskrgr]

Successful merges:

• std: use futex-based locks on Fuchsia #98707 (std: use futex-based locks on Fuchsia)
• Add PhantomData marker for dropck to BTreeMap #99413 (Add PhantomData marker for dropck to BTreeMap)
• Add map_continue and continue_value combinators to ControlFlow #99454 (Add map_continue and continue_value combinators to ControlFlow)
• Fix the stable version of AsFd for Arc<T> and Box<T> #99523 (Fix the stable version of AsFd for Arc<T> and Box<T>)
• Normalize the arg spans to be within the call span #99526 (Normalize the arg spans to be within the call span)
• couple of clippy::perf fixes #99528 (couple of clippy::perf fixes)
• Add regression test for #52304 #99549 (Add regression test for Compiler panic on type inference for impl Generator yielding a reference #52304)
• Rewrite orphan_check_trait_ref to use a TypeVisitor #99552 (Rewrite orphan_check_trait_ref to use a TypeVisitor)
• Edit rustc_index::vec::IndexVec::pick3_mut docs #99557 (Edit rustc_index::vec::IndexVec::pick3_mut docs)
• Fix remap_constness #99558 (Fix remap_constness)
• Remove unused field in ItemKind::KeywordItem #99559 (Remove unused field in ItemKind::KeywordItem)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=11

[bors]

📌 Commit af64d93 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit af64d93 with merge af7ab34...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing af7ab34 to master...

[rust-timer]

Finished benchmarking commit (af7ab34): comparison url.

Instruction count

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	0.5%	0.5%	1
Improvements 🎉 (primary)	-0.3%	-0.3%	4
Improvements 🎉 (secondary)	-0.7%	-1.0%	5
All 😿🎉 (primary)	-0.3%	-0.3%	4

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	5.8%	5.8%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.4%	-2.9%	5
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

• Primary benchmarks: 😿 relevant regressions found
• Secondary benchmarks: no relevant changes found

	mean1	max	count2
Regressions 😿 (primary)	2.3%	2.6%	3
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	2.3%	2.6%	3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[ComputerDruid]

This rollup started causing some code in fuchsia to fail to build. Minimized it to:

use std::collections::BTreeMap;
use std::io::Read;

pub fn example() {
    let mut path_content_map: BTreeMap<&str, (u64, Box<dyn Read>)> = BTreeMap::new();
    let s = format!("");
    let as_bytes = s.as_bytes();
    path_content_map.insert("foo", (as_bytes.len() as u64, Box::new(as_bytes)));
}

which gives:

error[E0597]: `s` does not live long enough
 --> src/lib.rs:7:20
  |
7 |     let as_bytes = s.as_bytes();
  |                    ^^^^^^^^^^^^ borrowed value does not live long enough
8 |     path_content_map.insert("foo", (as_bytes.len() as u64, Box::new(as_bytes)));
9 | }
  | -
  | |
  | `s` dropped here while still borrowed
  | borrow might be used here, when `path_content_map` is dropped and runs the `Drop` code for type `BTreeMap`
  |
  = note: values in a scope are dropped in the opposite order they are defined

For more information about this error, try `rustc --explain E0597`.
error: could not compile `repor_new_rust_failure` due to previous error

and cargo bisect-rustc identifies this rollup as the start of the regression. I'm not sure which PR is causing it yet though

[matthiaskrgr]

might be #99413

[ComputerDruid]

Yep, it's definitely #99413. Sounds like it may be intended. Thanks!