Prefer visibility map parents that are not doc(hidden) first

[compiler-errors]

Far simpler approach to #98876.

This only fixes the case where the parent is doc(hidden), not where the child is doc(hidden) since I don't know how to get the attrs on the import statement given a ModChild... I'll try to follow up with that, but this is a good first step.

[rust-highfive]

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

[cjgillot]

The best way to access the attributes on a ModChild would probably to add a DefId to the ModChild.
In the mean time, this implementation looks good enough.
@bors r+

[bors]

📌 Commit 42a4419 has been approved by cjgillot

It is now in the queue for this repository.

[jyn514]

This only fixes the case where the parent is doc(hidden), not where the child is doc(hidden) since I don't know how to get the attrs on the import statement given a ModChild... I'll try to follow up with that, but this is a good first step.

not sure how hard this is in rustc_metadata, but rustdoc does it like so:

rust/src/librustdoc/visit_ast.rs

Lines 51 to 59 in e1d1848

	pub(crate) fn inherits_doc_hidden(tcx: TyCtxt<'_>, mut node: hir::HirId) -> bool {
	while let Some(id) = tcx.hir().get_enclosing_scope(node) {
	node = id;
	if tcx.hir().attrs(node).lists(sym::doc).has_word(sym::hidden) {
	return true;
	}
	}
	false
	}

[pnkfelix]

@compiler-errors any chance that this contributed to the regression reported in #99792 (comment) ?

[compiler-errors]

Yes very likely.