Closed
Conversation
Using `F_KINFO` fcntl flag, the kf_structsize field needs to be set beforehand for that effect.
Remove reachable coverage without counters to maintain invariant that
either there is no coverage at all or there is a live coverage counter
left that provides the function source hash.
The motivating example would be a following closure:
```rust
let f = |x: bool| {
debug_assert!(x);
};
```
Which, with span changes from rust-lang#93967, with disabled debug assertions,
after the final CFG simplifications but before removal of dead blocks,
gives rise to MIR:
```rust
fn main::{closure#0}(_1: &[closure@a.rs:2:13: 2:22], _2: bool) -> () {
debug x => _2;
let mut _0: ();
bb0: {
Coverage::Expression(4294967295) = 1 - 2;
return;
}
...
}
```
Constify a few `(Partial)Ord` impls Only a few `impl`s are constified for now, as rust-lang#92257 has not landed in the bootstrap compiler yet and quite a few impls would need that fix. This unblocks rust-lang#92228, which unblocks marking iterator methods as `default_method_body_is_const`.
…imulacrum Implement `fs::get_path` for FreeBSD. Using `F_KINFO` fcntl flag, the kf_structsize field needs to be set beforehand for that effect.
correct the output of a `capacity` method example The output of this example in std::alloc is different from which shown in the comment. I have tested it on both Linux and Windows.
clarify how write_bytes can lead to UB due to invalid values Fixes rust-lang/unsafe-code-guidelines#330 Cc `@5225225`
…li-obk don't ICE on invalid dyn calls Due to rust-lang#50781 this is actually reachable. Fixes rust-lang/miri#2432 r? `@oli-obk`
Remove reachable coverage without counters
Remove reachable coverage without counters to maintain invariant that
either there is no coverage at all or there is a live coverage counter
left that provides the function source hash.
The motivating example would be a following closure:
```rust
let f = |x: bool| {
debug_assert!(x);
};
```
Which, with span changes from rust-lang#93967, with disabled debug assertions,
after the final CFG simplifications but before removal of dead blocks,
gives rise to MIR:
```rust
fn main::{closure#0}(_1: &[closure@a.rs:2:13: 2:22], _2: bool) -> () {
debug x => _2;
let mut _0: ();
bb0: {
Coverage::Expression(4294967295) = 1 - 2;
return;
}
...
}
```
Which also makes the initial instrumentation quite suspect, although
this pull request doesn't attempt to address that aspect directly.
Fixes rust-lang#98833.
r? `@wesleywiser` `@richkadel`
…-conversions, r=michaelwoerister Avoid `&str`/`Symbol` to `String` conversions follow-up to rust-lang#99342 and rust-lang#98668
rustbot
added
T-compiler
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 6cba515 with merge 9689175677a7064ec479c4f4e70b459374c22fa3... |
Collaborator
|
💔 Test failed - checks-actions |
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-review
Member
|
#98211 looks like hte offender. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
(Partial)Ordimpls #92390 (Constify a few(Partial)Ordimpls)fs::get_pathfor FreeBSD. #98211 (Implementfs::get_pathfor FreeBSD.)capacitymethod example #98710 (correct the output of acapacitymethod example)&str/SymboltoStringconversions #99718 (Avoid&str/SymboltoStringconversions)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup