Closed
Conversation
This error message is about `derive` and `packed`, but E0133 is for "Unsafe code was used outside of an unsafe function or block".
handle consts with param/infer in `const_eval_resolve` better This PR addresses [this thread here](rust-lang#99449 (comment)). Was this the change you were looking for `@lcnr?` Interestingly, one test has begun to pass. Was that expected? r? `@lcnr`
Restore `Opaque` behavior to coherence check Fixes rust-lang#99663. This broke in 84c3fcd. I'm not exactly certain that adding this behavior back is necessarily correct, but at least the UI test I provided may stimulate some thoughts. I think delaying a bug here is certainly not correct in the case of opaques -- if we want to change coherence behavior for opaques, then we should at least be emitting a new error. r? `@lcnr`
interpret, ptr_offset_from: refactor and test too-far-apart check We didn't have any tests for the "too far apart" message, and indeed that check mostly relied on the in-bounds check and was otherwise probably not entirely correct... so I rewrote that check, and it is before the in-bounds check so we can test it separately.
Remove erroneous E0133 code from an error message. This error message is about `derive` and `packed`, but E0133 is for "Unsafe code was used outside of an unsafe function or block". r? `@estebank`
…rinting, r=fee1-dead Use full type name instead of just saying `impl Trait` in "captures lifetime" error I think this is very useful, especially when there's >1 `impl Trait`, and it just means passing around a bit more info that we already have access to.
rustbot
added
T-compiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
const_eval_resolvebetter #99618 (handle consts with param/infer inconst_eval_resolvebetter)Opaquebehavior to coherence check #99666 (RestoreOpaquebehavior to coherence check)impl Traitin "captures lifetime" error #99748 (Use full type name instead of just sayingimpl Traitin "captures lifetime" error)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup