perf: revert #99212

[davidtwco]

Reverts #99212 to check the performance impact of that pull request. I don't expect that we'll need to land this - if a perf impact is revealed then I'll submit a new PR that fixes it.

[rust-highfive]

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

[davidtwco]

r? @ghost

[davidtwco]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 4078ee4 with merge cd02069df6812a8a1be9589e05a040bb6fc16b4e...

[bors]

☀️ Try build successful - checks-actions
Build commit: cd02069df6812a8a1be9589e05a040bb6fc16b4e (cd02069df6812a8a1be9589e05a040bb6fc16b4e)

[rust-timer]

Queued cd02069df6812a8a1be9589e05a040bb6fc16b4e with parent 2f847b8, future comparison URL.

[rust-timer]

Finished benchmarking commit (cd02069df6812a8a1be9589e05a040bb6fc16b4e): comparison url.

Instruction count

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	0.8%	1.0%	3
Improvements 🎉 (primary)	-1.3%	-2.6%	8
Improvements 🎉 (secondary)	-1.1%	-2.4%	39
All 😿🎉 (primary)	-1.3%	-2.6%	8

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	3.4%	3.4%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-3.0%	-3.1%	2
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: 😿 relevant regression found

	mean1	max	count2
Regressions 😿 (primary)	2.7%	2.9%	2
Regressions 😿 (secondary)	2.6%	2.6%	1
Improvements 🎉 (primary)	-2.7%	-3.0%	2
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-0.0%	-3.0%	4

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[davidtwco]

It should be possible to negate the perf impact of #99212, I'll look into it and close this for now.