update rustfmt references to reflect change from submod to subtree#1129
Merged
LeSeulArtichaut merged 2 commits intorust-lang:masterfrom May 20, 2021
Merged
update rustfmt references to reflect change from submod to subtree#1129LeSeulArtichaut merged 2 commits intorust-lang:masterfrom
LeSeulArtichaut merged 2 commits intorust-lang:masterfrom
Conversation
RalfJung
reviewed
May 18, 2021
src/contributing.md
Outdated
| @@ -270,7 +270,7 @@ because the rust-lang/rust build won't pass until those tools build and pass the | |||
| tests. | |||
|
|
|||
| That means that, in the default state, you can't update the compiler without first | |||
Member
There was a problem hiding this comment.
Suggested change
| That means that, in the default state, you can't update the compiler without first | |
| That would mean that, in the default state, you couldn't update the compiler without first |
I still find this sentence very confusing, but now at least it is clearly non-factual.
(I also realize this is pre-existing.)
Member
Author
There was a problem hiding this comment.
Yes! I'm so glad I'm not the only one that was confused by this. It gave me a brief scare initially because I didn't realize until I'd gotten a few paragraphs in that it was actually describing a past or hypothetical state, but using present-tense prose. Applied in ed0c82b
RalfJung
reviewed
May 18, 2021
Member
|
LGTM. :) |
LeSeulArtichaut
approved these changes
May 18, 2021
Contributor
LeSeulArtichaut
left a comment
LeSeulArtichaut
left a comment
There was a problem hiding this comment.
Thanks! I'll merge with Ralf's nit fixed
calebcartwright
force-pushed
the
rustfmt-subtree
branch
from
884cdec to
ed0c82b
Compare
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
May 26, 2021
Update books ## reference 4 commits in 5aa457bf1b54bd2cd5d4cf49797f29299bdf89a7..9c68af3ce6ccca2395e1868addef26a0542e9ddd 2021-05-05 08:39:22 -0700 to 2021-05-24 09:53:32 -0700 - missing parameter name in Trait Implementations (rust-lang/reference#1030) - Add more content to impl-trait.md (rust-lang/reference#1017) - Document extended key-value attributes (rust-lang/reference#1029) - Document raw pointer <-> usize casts. (rust-lang/reference#970) ## rust-by-example 1 commits in 5f8c6da200ada77760a2fe1096938ef58151c9a6..805e016c5792ad2adabb66e348233067d5ea9f10 2021-04-29 08:08:01 -0300 to 2021-05-20 17:08:34 -0300 - Update structs.md (rust-lang/rust-by-example#1440) ## rustc-dev-guide 4 commits in 1e6c7fb..50de7f0 2021-05-10 13:38:24 +0900 to 2021-05-20 15:02:20 +0200 - update rustfmt references to reflect change from submod to subtree (rust-lang/rustc-dev-guide#1129) - Remove `--stage 1` argument from `doc` invocations (rust-lang/rustc-dev-guide#1125) - Update coverage docs (rust-lang/rustc-dev-guide#1122) - Document -Zunpretty=thir-tree (rust-lang/rustc-dev-guide#1128) ## edition-guide 1 commits in 1da3c411f17adb1ba5de1683bb6acee83362b54a..302a115e8f71876dfc884aebb0ca5ccb02b8a962 2021-02-16 16:46:40 -0800 to 2021-05-21 10:46:11 -0400 - Minimize the edition guide (rust-lang/edition-guide#232) ## embedded-book 1 commits in 569c3391f5c0cc43433bc77831d17f8ff4d76602..7349d173fa28a0bb834cf0264a05286620ef0923 2021-04-07 08:32:11 +0000 to 2021-05-25 13:59:05 +0000 - Remove $ from cargo-binutils (rust-embedded/book#292)
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
May 26, 2021
Update books ## reference 4 commits in 5aa457bf1b54bd2cd5d4cf49797f29299bdf89a7..9c68af3ce6ccca2395e1868addef26a0542e9ddd 2021-05-05 08:39:22 -0700 to 2021-05-24 09:53:32 -0700 - missing parameter name in Trait Implementations (rust-lang/reference#1030) - Add more content to impl-trait.md (rust-lang/reference#1017) - Document extended key-value attributes (rust-lang/reference#1029) - Document raw pointer <-> usize casts. (rust-lang/reference#970) ## rust-by-example 1 commits in 5f8c6da200ada77760a2fe1096938ef58151c9a6..805e016c5792ad2adabb66e348233067d5ea9f10 2021-04-29 08:08:01 -0300 to 2021-05-20 17:08:34 -0300 - Update structs.md (rust-lang/rust-by-example#1440) ## rustc-dev-guide 4 commits in 1e6c7fb..50de7f0 2021-05-10 13:38:24 +0900 to 2021-05-20 15:02:20 +0200 - update rustfmt references to reflect change from submod to subtree (rust-lang/rustc-dev-guide#1129) - Remove `--stage 1` argument from `doc` invocations (rust-lang/rustc-dev-guide#1125) - Update coverage docs (rust-lang/rustc-dev-guide#1122) - Document -Zunpretty=thir-tree (rust-lang/rustc-dev-guide#1128) ## edition-guide 1 commits in 1da3c411f17adb1ba5de1683bb6acee83362b54a..302a115e8f71876dfc884aebb0ca5ccb02b8a962 2021-02-16 16:46:40 -0800 to 2021-05-21 10:46:11 -0400 - Minimize the edition guide (rust-lang/edition-guide#232) ## embedded-book 1 commits in 569c3391f5c0cc43433bc77831d17f8ff4d76602..7349d173fa28a0bb834cf0264a05286620ef0923 2021-04-07 08:32:11 +0000 to 2021-05-25 13:59:05 +0000 - Remove $ from cargo-binutils (rust-embedded/book#292)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustfmt was recently changed from a submodule to a subtree (rust-lang/rust#82208) so this accordingly updates a few rustfmt submodule references
cc @RalfJung and @Xanewok, as I largely did a lazy replacement of rustfmt wording in submodule-related sections with miri or rls since those seem to be the most used. Please let me know if any of those changes are off base though for your respective tools