Fix `rustc_mir` related links by Lee-Janggun · Pull Request #1228 · rust-lang/rustc-dev-guide

Lee-Janggun · 2021-10-09T13:48:06Z

With Split rustc_mir rust#80522, rustc_mir has been split into 5 crates, effectively invalidating all related links
This PR fixes such links, with a few issues.

The "main" MIR page

As seen in https://github.com/rust-lang/rustc-dev-guide/blob/master/src/overview.md, there is a direct link to the rustc_mir crate, which has been split into 5. As the split crates do not have a representative for "the MIR crate", I was unable to make a choice
The other page with such link is https://github.com/rust-lang/rustc-dev-guide/blob/master/src/mir/index.md

NoLandingPads

Some docs have links to the now removed NoLandingPads optimization. Similar to above, I was unable to make a choice here and left it as is.
The places where such is mentioned that I have found are four
Related: Update link for NoLandingPads #1214, rustc: Fill out remaining parts of C-unwind ABI rust#86155.

Hardcoded Versions

In src/sanitizers.md, there are a few hardcoded links to docs version 1.55.0 that point to the rustc_mir crate. I wasn't sure how to change this so I left it as is.

I'm not sure, but I think the name of the function must have been changed during the move. The link as it was went to the `InterpCx` struct but didn't jump down to the function

nhamovitz · 2021-10-18T07:11:43Z

Opened #2 on @Lee-Janggun's branch — one of the functions was also renamed during the move, so the jump-to-function with the html id wasn't working

src/borrow_check.md

src/mir/optimizations.md

src/mir/passes.md

JohnTitor · 2021-10-20T06:27:22Z

The "main" MIR page: Let's mention all the rustc_mir_* crates, "manipulates" has a wide range of interpretations.
NoLandingPads: It's tracked on Fix NoLandingPads documentation #1232 and would perhaps need some discussion, let's skip for now.
Hardcoded Versions: The doc was updated recently (Update sanitizer documentation #1220) and it seems fine to leave as-is.

Co-authored-by: Yuki Okushi <jtitor@2k36.org>

Lee-Janggun · 2021-10-21T03:08:15Z

I'll work on the rest near the weekend. Is it possible for me to change the tag?

JohnTitor · 2021-10-21T04:22:57Z

You could do via a comment: @rustbot label: -waiting-on-review +waiting-on-author

Lee-Janggun · 2021-10-27T12:46:31Z

I applied the comments, and also added comments to where NoLandingPads were mentioned for future reference.

@rustbot label: +waiting-on-review -waiting-on-author

src/mir/index.md

JohnTitor

Almost LGTM, applied some minor fixes via 184d33c. Thanks for working on it!

Update books ## nomicon 1 commits in 358e6a61d5f4f0496d0a81e70cdcd25d05307342..c6b4bf831e9a40aec34f53067d20634839a6778b 2021-10-20 11:23:12 -0700 to 2021-11-09 02:30:56 +0900 - Replace some use of variant with covariant (rust-lang/nomicon#322) ## book 11 commits in fd9299792852c9a368cb236748781852f75cdac6..5c5dbc5b196c9564422b3193264f3288d2a051ce 2021-10-22 21:59:46 -0400 to 2021-11-09 19:30:43 -0500 - Fix constants link. - Fix updated anchor - Propagate edits to chapter 2 back - Edits to nostarch's chapter 3 edits - ch 3 from nostarch - Fix Cargo.toml snippet about custom derive macros - Snapshot of chapter 9 for nostarch - Create tmp/src for converting quotes, not sure why this broke but ok - Update question mark to better explain where it can be used - Clarify sentence about Results in functions that don't return Result. Fixes rust-lang/book#2912. - Merge pull request rust-lang/book#2913 from covariant/patch-1 ## rust-by-example 2 commits in 27f1ff5e440ef78828b68ab882b98e1b10d9af32..e9d45342d7a6c1def4731f1782d87ea317ba30c3 2021-10-13 08:04:40 -0300 to 2021-11-02 13:33:03 -0500 - Enums: Linked-List Needs Re-Wording (rust-lang/rust-by-example#1469) - fix: Use the point as top left corner for `square` (rust-lang/rust-by-example#1471) ## rustc-dev-guide 13 commits in b060087..196ef69 2021-10-21 15:13:09 -0500 to 2021-11-07 07:48:47 -0600 - Fix typo: [upv.rs_mentioned] -> [upvars_mentioned] - Add note to emphasize replacing TARGET_TRIPLE (rust-lang/rustc-dev-guide#1250) - Remove some legacy test suites. - tiny capitalization fix - Fix date - Update some date-check comments - Ensure date-check cron job is using latest stable Rust - enhance subtree docs, link to clippy docs - Edit introduction to bootstrapping - Some minor adjustments to the diagnostic documentation - Edit "About this guide" for semantic line feeds - Fix `rustc_mir` related links (rust-lang/rustc-dev-guide#1228) - Add documentation for LLVM CFI support ## edition-guide 3 commits in 7c0088ca744d293a5f4b1e2ac378e7c23d30fe55..27f4a84d3852e9416cae5861254fa53a825c56bd 2021-10-05 13:28:05 +0200 to 2021-11-08 10:13:20 -0500 - Add a missing period (rust-lang/edition-guide#271) - Fix syntax error in code example (rust-lang/edition-guide#270) - Fixed an example error of prelude.md (rust-lang/edition-guide#269)

Co-authored-by: Yuki Okushi <jtitor@2k36.org> Co-authored-by: nhamovitz <18648574+nhamovitz@users.noreply.github.com>

Lee-Janggun added 9 commits October 9, 2021 22:03

Update optimizations.md

60505e3

Update dataflow.md

f6d88af

Update lifetime_parameters.md

586ad37

Update rustc_mir/* links

d3bce46

Update rustc_mir/* links, Fix rustc_mir/index.html

2562e29

Update rustc_mir links. Fix NoLandingPads

2e1002a

Update rustc_mir::. Fix NoLandingPads

172a32a

Update move_paths.md

d58ecc3

Merge branch 'master' of https://github.com/Lee-Janggun/rustc-dev-guide

01a970e

camelid added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Oct 12, 2021

camelid linked an issue Oct 12, 2021 that may be closed by this pull request

Update links to rustc_mir to use the new names #1225

Closed

JohnTitor self-requested a review October 17, 2021 17:18

Update function name

1746afe

I'm not sure, but I think the name of the function must have been changed during the move. The link as it was went to the `InterpCx` struct but didn't jump down to the function

nhamovitz and others added 2 commits October 18, 2021 00:23

Fix op_to_const in miri.md

ed17688

Merge pull request #2 from nhamovitz/patch-2

39eb2de

JohnTitor reviewed Oct 20, 2021

View reviewed changes

src/borrow_check.md Outdated Show resolved Hide resolved

src/mir/optimizations.md Outdated Show resolved Hide resolved

src/mir/passes.md Outdated Show resolved Hide resolved

Lee-Janggun and others added 2 commits October 20, 2021 17:33

Update src/mir/passes.md

d97216e

Co-authored-by: Yuki Okushi <jtitor@2k36.org>

Update basic names from review.

13edfd4

Co-authored-by: Yuki Okushi <jtitor@2k36.org>

rustbot added S-waiting-on-author Status: this PR is waiting for additional action by the OP and removed S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content labels Oct 21, 2021

Lee-Janggun added 2 commits October 27, 2021 21:40

rustc_mir crate link -> rustc_mir_* crate links

0dfa607

Add issue related to NoLandingPads

f100b2b

rustbot added S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content and removed S-waiting-on-author Status: this PR is waiting for additional action by the OP labels Oct 27, 2021

Make line length < 100

ed7dde8

JohnTitor reviewed Oct 28, 2021

View reviewed changes

src/mir/index.md Outdated Show resolved Hide resolved

src/mir/index.md Outdated Show resolved Hide resolved

Apply suggestions from code review

184d33c

JohnTitor approved these changes Oct 28, 2021

View reviewed changes

JohnTitor merged commit ddaebd8 into rust-lang:master Oct 28, 2021

ehuss mentioned this pull request Nov 10, 2021

Update books rust-lang/rust#90751

Merged

Kobzol pushed a commit to Kobzol/rustc-dev-guide that referenced this pull request Jan 3, 2025

Fix rustc_mir related links (rust-lang#1228)

d03c7b8

Co-authored-by: Yuki Okushi <jtitor@2k36.org> Co-authored-by: nhamovitz <18648574+nhamovitz@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `rustc_mir` related links#1228

Fix `rustc_mir` related links#1228
JohnTitor merged 18 commits intorust-lang:masterfrom
Lee-Janggun:master

Lee-Janggun commented Oct 9, 2021 •

edited

Loading

Uh oh!

nhamovitz commented Oct 18, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JohnTitor commented Oct 20, 2021

Uh oh!

Lee-Janggun commented Oct 21, 2021

Uh oh!

JohnTitor commented Oct 21, 2021

Uh oh!

Lee-Janggun commented Oct 27, 2021

Uh oh!

Uh oh!

Uh oh!

JohnTitor left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Lee-Janggun commented Oct 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nhamovitz commented Oct 18, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JohnTitor commented Oct 20, 2021

Uh oh!

Lee-Janggun commented Oct 21, 2021

Uh oh!

JohnTitor commented Oct 21, 2021

Uh oh!

Lee-Janggun commented Oct 27, 2021

Uh oh!

Uh oh!

Uh oh!

JohnTitor left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Lee-Janggun commented Oct 9, 2021 •

edited

Loading