Update CoverageMapping Format Version requirements#1235
Update CoverageMapping Format Version requirements#1235Swatinem wants to merge 1 commit intorust-lang:masterfrom
Conversation
src/llvm-coverage-instrumentation.md
Outdated
|
|
||
| [^llvm-and-covmap-versions]: The Rust compiler (as of | ||
| January 2021) supports _LLVM Coverage Mapping Format_ Version 4 (the most | ||
| October 2021) supports _LLVM Coverage Mapping Format_ Version 5 (the most |
There was a problem hiding this comment.
Version 5 is not the "most current version". The most current version is version 6.
(But I am wondering why not upgrade to version 6 and skip 5.)
|
Good point, might as well jump to v6. I was under the impression that we should keep compatibility with lower versions as much as we can to get the features we need. Also, I haven’t looked at it in too much detail yet, so I don’t know yet if the v6 changes need other code changes as well. |
|
The description here makes it sound like a minor change, but please take a look and update this thread if it appears more complex than that. |
|
cc: @tmandry @wesleywiser |
c5a62ad to
e90db83
Compare
|
@richkadel I updated to v6. The format is backwards compatible if you only use absolute filenames. |
|
Since I will be OOO for 3 weeks, please ask @tmandry or @wesleywiser to review, when you are ready. Thanks again for these contributions! |
| (Version 4).[^llvm-and-covmap-versions] | ||
| (Version 6).[^llvm-and-covmap-versions] | ||
|
|
||
| [^llvm-and-covmap-versions]: The Rust compiler (as of |
There was a problem hiding this comment.
Could you add a machine-checkable date comment?
| [^llvm-and-covmap-versions]: The Rust compiler (as of | |
| [^llvm-and-covmap-versions]: The Rust compiler (as of <!-- date: 2021-11 --> |
There was a problem hiding this comment.
I made this change in the revised PR #1267.
This is the companion to rust-lang/rust#90047.
r? @richkadel