Region inference member constraints#344
Merged
mark-i-m merged 30 commits intorust-lang:masterfrom Jun 26, 2019
Merged
Conversation
2 tasks
Contributor
|
@nikomatsakis Are you saying that we should wait for you to push more? |
Contributor
Author
|
Yes. |
mark-i-m
added
the
S-waiting-on-author
Contributor
Author
|
OK, I pushed a lot more content now. |
3 tasks
lqd
reviewed
Jun 20, 2019
lqd
reviewed
Jun 20, 2019
lqd
reviewed
Jun 20, 2019
lqd
reviewed
Jun 20, 2019
lqd
reviewed
Jun 20, 2019
| 'd: 'c | ||
| ``` | ||
|
|
||
| Here we have two SCCs: S0 contains `'a` and `'b`, and S1 contains `'c` |
Member
There was a problem hiding this comment.
Suggested change
| Here we have two SCCs: S0 contains `'a` and `'b`, and S1 contains `'c` | |
| Here we have two SCCs: `S0` contains `'a` and `'b`, and S1 contains `'c` |
lqd
reviewed
Jun 20, 2019
lqd
reviewed
Jun 20, 2019
lqd
reviewed
Jun 20, 2019
lqd
reviewed
Jun 20, 2019
lqd
reviewed
Jun 20, 2019
lqd
reviewed
Jun 20, 2019
lqd
reviewed
Jun 20, 2019
lqd
reviewed
Jun 20, 2019
lqd
reviewed
Jun 20, 2019
lqd
reviewed
Jun 20, 2019
lqd
reviewed
Jun 20, 2019
lqd
reviewed
Jun 20, 2019
Member
|
wow, these are so good ! |
mark-i-m
approved these changes
Jun 21, 2019
Contributor
mark-i-m
left a comment
mark-i-m
left a comment
There was a problem hiding this comment.
Looks great! I was wondering what the SCC stuff was.
There are a bunch of nits/suggestions, but they are mostly typos, minor things.
| @@ -0,0 +1,3 @@ | |||
| # Reporting region errors | |||
|
|
|||
| TODO: we should discuss how to generate errors from the results of these analyses. | |||
Contributor
There was a problem hiding this comment.
I can actually write a bit here from working on rust-lang/rust#58281
src/borrow_check/region_inference/placeholders_and_universes.md
Outdated
Show resolved
Hide resolved
src/borrow_check/region_inference/placeholders_and_universes.md
Outdated
Show resolved
Hide resolved
src/borrow_check/region_inference/placeholders_and_universes.md
Outdated
Show resolved
Hide resolved
src/borrow_check/region_inference/placeholders_and_universes.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: lqd <remy.rakic+github@gmail.com>
Co-Authored-By: lqd <remy.rakic+github@gmail.com>
Co-Authored-By: lqd <remy.rakic+github@gmail.com>
Co-Authored-By: lqd <remy.rakic+github@gmail.com>
Co-Authored-By: lqd <remy.rakic+github@gmail.com>
Co-Authored-By: lqd <remy.rakic+github@gmail.com>
Co-Authored-By: lqd <remy.rakic+github@gmail.com>
Co-Authored-By: lqd <remy.rakic+github@gmail.com>
Co-Authored-By: lqd <remy.rakic+github@gmail.com>
Co-Authored-By: lqd <remy.rakic+github@gmail.com>
Co-Authored-By: lqd <remy.rakic+github@gmail.com>
Co-Authored-By: lqd <remy.rakic+github@gmail.com>
Co-Authored-By: lqd <remy.rakic+github@gmail.com>
Co-Authored-By: lqd <remy.rakic+github@gmail.com>
Co-Authored-By: lqd <remy.rakic+github@gmail.com>
Co-Authored-By: Who? Me?! <mark-i-m@users.noreply.github.com>
Co-Authored-By: lqd <remy.rakic+github@gmail.com>
Co-Authored-By: Who? Me?! <mark-i-m@users.noreply.github.com>
Co-Authored-By: Who? Me?! <mark-i-m@users.noreply.github.com>
Co-Authored-By: Who? Me?! <mark-i-m@users.noreply.github.com>
Co-Authored-By: Who? Me?! <mark-i-m@users.noreply.github.com>
Co-Authored-By: Who? Me?! <mark-i-m@users.noreply.github.com>
Contributor
|
@nikomatsakis r=me when CI is green. There is one long line (in the ToC, lol): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started working on expanding the chapter on region inference, so as to better document rust-lang/rust#61775. Didn't really get to member constraints yet.