Merged
Conversation
arora-aman
reviewed
May 27, 2020
JohnTitor
reviewed
May 28, 2020
Member
JohnTitor
left a comment
There was a problem hiding this comment.
Left some thoughts:
- I'd mention this chapter in somewhere of "How to Build and Run the Compiler"
- I'd also have a link to rust-lang/rust README since it should be up-to-date than here
This comment has been minimized.
This comment has been minimized.
Contributor
jyn514
reviewed
Jun 17, 2020
a974445 to
bb3a6cd
Compare
Contributor
Contributor
|
I don't understand the current CI failure... |
Member
|
Works for me locally. Not sure what's going on in CI. You can reproduce by adding github to the ignore list: |
96fec7f to
46e2397
Compare
46e2397 to
071c59f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #722
Currently only includes instructions for Windows, I didn't have a Linux machine available.
Taken from @yoshuawuyts instructions.