More Clippy lint groups including pedantic#51
Open
allan2 wants to merge 10 commits intorust-lang:masterfrom
Open
More Clippy lint groups including pedantic#51allan2 wants to merge 10 commits intorust-lang:masterfrom
allan2 wants to merge 10 commits intorust-lang:masterfrom
Conversation
There were also warnings for math formulae and names like SipHash. No change at this time.
WaffleLapkin
requested changes
Sep 12, 2024
Member
WaffleLapkin
left a comment
There was a problem hiding this comment.
cast_lossless and cargo_common_metadata fixes are a nice touch. everything else however doesn't look like an improvement to me.
fbstj
reviewed
Sep 12, 2024
Co-authored-by: Joe ST <joe@fbstj.net>
Contributor
Author
|
I could remove the nursery group if maintainers prefer, as it is an experimental group.
|
Contributor
Author
|
I've just kept the pedantic and cargo lint groups now. This is in line with rust-lang/cargo-bisect-rustc and rust-lang/rustc-perf. |
Member
|
I did not change my opinions since #51 (review) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five lints corrected:
doc_markdownfrompedantic(partial, see commit message)cast_losslessfrompedanticuse_selffromnurserytoo_long_first_doc_paragraphfromstylecargo_common_metadatafromcargoPedantic, nursery, and cargo group rules are added.
All lints are passing.