Migrate ctfe-stress-test-3 to ctfe-stress-test-4#552
Merged
Mark-Simulacrum merged 1 commit intorust-lang:masterfrom Nov 12, 2019
davidhewitt:ctfe-stress-test-4
Merged
Migrate ctfe-stress-test-3 to ctfe-stress-test-4#552Mark-Simulacrum merged 1 commit intorust-lang:masterfrom davidhewitt:ctfe-stress-test-4
Mark-Simulacrum merged 1 commit intorust-lang:masterfrom
davidhewitt:ctfe-stress-test-4
Conversation
If rust PR #66294 lands then evaluation of `const fn` with no arguments will be memoized. This breaks the purpose of the tests in ctfe-stress-3, so this PR changes to a new ctfe-stress-test-4 which is identical save that the const functions now take a dummy u32 argument to avoid memoization.
Contributor
|
@bors r+ |
Member
|
Does it make sense to keep around a memoized case (though maybe smaller) so we can detect if memoization regresses in the future? |
Contributor
|
We already test the memoization in the rustc test suite by causing cycles on recursion |
Member
|
Okay, great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If rust-lang/rust#66294 lands then evaluation of
const fnwith no arguments will be memoized. This breaks the purpose of the tests in ctfe-stress-3.This PR changes to a new ctfe-stress-test-4 which is identical save that the const functions now take a dummy u32 argument to avoid memoization.
r? @oli-obk