update.sh: Make user, repo, and branch easy to change#14
Merged
aDotInTheVoid merged 1 commit intorust-lang:trunkfrom Aug 20, 2022
Merged
update.sh: Make user, repo, and branch easy to change#14aDotInTheVoid merged 1 commit intorust-lang:trunkfrom
aDotInTheVoid merged 1 commit intorust-lang:trunkfrom
Conversation
Member
Author
|
@aDotInTheVoid Any chance you could take a look at this please? I used it again for rust-lang/rust#100762 and find it very useful. The diff might look compilicated, but it's very simple actually. I just extract hardcoded strings into variables. Let me know if you have any concerns and we'll sort them out somehow! |
Member
|
No concerns, just hadn't gotten around to looking over it, and it seemed non-urgent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easy for me to try out e.g. rust-lang/rust#99787 by temporarily doing the following change in the script and then run it:
IMHO it would be overkill (and more complicated to use) if we made these changeable by script args ($2 $3 $4) instead, so I prefer this.