Fix CFG_RELEASE value#4202
Merged
topecongiro merged 1 commit intorust-lang:masterfrom May 25, 2020
sagiegurari:master
Merged
Conversation
topecongiro
approved these changes
May 25, 2020
Contributor
topecongiro
left a comment
topecongiro
left a comment
There was a problem hiding this comment.
Thank you for the PR! As you say, it seems that the correct value for CFG_RELEASE is the version of the Rust compiler.
I was not aware of CARGO_MAKE_RUST_VERSION and CARGO_MAKE_RUST_CHANNEL; it's nice to know about them.
bradleypmartin
pushed a commit
to bradleypmartin/rustfmt
that referenced
this pull request
May 25, 2020
Contributor
|
backport not needed, master doesn't have that makefile |
karyon
added
1x-backport:completed
1x-backport:n/a
and removed
backport-triage
1x-backport:completed
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue while using rustfmt and found rust-lang/rust#72423
I saw how you solved it locally and decided to do the same as well, but the actual values provided are not accurate.
I believe CFG_RELEASE should hold the rustc version number and not channel.
so this should hopefully provide a more accurate value.