Implement formatting for let_chains#5495
Closed
goffrie wants to merge 2 commits intorust-lang:masterfrom
Closed
Conversation
Member
|
Thank you for the contribution but I am going to close as this is a duplicate of another PR that is currently blocked. More info in the summary in #5203 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if-statements with let chains in them are completely skipped, because
format_exprfails on theExprKind::Let.Implement it by copying some logic from
ControlFlow::rewrite_pat_expr. Then, simplifyControlFlowby removing explicit support forif let/while let, instead delegating toformat_expr. Some logic still remains to supportfor <pat> in <expr>, however.