Open
Conversation
Implement skipping logic just like rustfmt does. rustfmt would ignore these files anyway so we can save some time and effort if we avoid spawning a subprocess for files that we know rustfmt is going to ignore anyway. This saves a significant amount of time, especially for repositories like r-l/rust which ignore a lot of files.
These repos are explicitly skipped by r-l/rust's `rustfmt.toml` so i'm adding them to include them in the diff check.
rustbot
added
A-CI
Contributor
Author
|
Shaves off another few minutes even after adding two more repos to check: Before: After: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement skipping logic just like rustfmt does. rustfmt would ignore these files anyway so we can save some time and effort if we avoid shelling out to rustfmt if we know rustfmt is going to ignore these files anyway.
This saves a significant amount of time, especially for repositories like
r-l/rustwhich ignore a lot of files.