Fixup ci errors. Clippy on beta channel is broken#1977
Closed
baloo wants to merge 1 commit intorust-lang:masterfrom
baloo:baloo/fixup-ci
Closed
Fixup ci errors. Clippy on beta channel is broken#1977baloo wants to merge 1 commit intorust-lang:masterfrom baloo:baloo/fixup-ci
baloo wants to merge 1 commit intorust-lang:masterfrom
baloo:baloo/fixup-ci
Conversation
Clippy on beta is broken and reports like:
```
error: cannot find macro `pre_install_msg_template!` in this scope
--> src/cli/self_update.rs:98:9
|
98 | pre_install_msg_template!(
| ^^^^^^^^^^^^^^^^^^^^^^^^
error: cannot find macro `pre_install_msg_template!` in this scope
--> src/cli/self_update.rs:109:9
|
109 | pre_install_msg_template!(
| ^^^^^^^^^^^^^^^^^^^^^^^^
error: cannot find macro `pre_install_msg_template!` in this scope
--> src/cli/self_update.rs:118:9
|
118 | pre_install_msg_template!(
| ^^^^^^^^^^^^^^^^^^^^^^^^
warning: unused macro definition
--> src/cli/self_update.rs:62:1
|
62 | / macro_rules! pre_install_msg_template {
63 | | ($platform_msg: expr) => {
64 | | concat!(
65 | | r"
... |
93 | | };
94 | | }
| |_^
|
= note: `#[warn(unused_macros)]` on by default
```
This does not happens on neither stable nor nightly channel.
Signed-off-by: Arthur Gautier <baloo@gandi.net>
Contributor
|
Hi, We are very aware that beta's The fix hit nightly from rust-lang/rust#63717 and we're waiting on a beta backport for now. Thanks again for your contribution, but we won't be taking this at this time. |
Author
|
makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clippy on beta is broken and reports like:
This does not happens on neither stable nor nightly channel.