Conversation
b733d4d to
5d88e4b
Compare
|
@psumbera Thanks for your contribution! Have you (temporarily) removed |
No. To be honest I'm trying to find out how it's working... So I removed them from |
|
@psumbera As a friendly hint, we often do it like so: do the normal PR first, add a |
@psumbera That's right, but you'll also need to run the shell script to update the GitHub CI YAML to keep them in sync, otherwise the CI will fail anyway. |
90b2501 to
b7170ec
Compare
df3ac91 to
7980c8c
Compare
rami3l
left a comment
There was a problem hiding this comment.
Many thanks for this PR, and LGTM (modulo the comments)!
|
@psumbera Many thanks again for your contribution! As a follow-up question, is browser detection on https://dev.rustup.rs working alright on Solaris? (I assume it's working alright on x64, but you are adding support for For example, for other unices we have: Lines 36 to 40 in 452c8e5 |
So far I wasn't able to test it. |
@psumbera Sorry for not being clear enough previously; I meant the Web frontend part of the detection specifically, since we'd normally assume a host platform (anything tier 1, or tier 2 with host tools) can run a browser and the user might want to go to the website for installation instructions.
This is expected; merging the PR only gets it into our code base and the actual deployment will happen in the next release. Although I cannot say for sure when that will come, I'd say that we are trying our best to make releases happen more often. |
See attached screen shot what I get on Solaris SPARC in Firefox 128.9.0. I think it's ok.
|

Rustup should be built also for Solaris (after rust-lang/rust#138699).