make MsgHdr and MsgHdrMut repr(transparent)#635
make MsgHdr and MsgHdrMut repr(transparent)#635Thomasdezeeuw merged 1 commit intorust-lang:masterfrom
MsgHdr and MsgHdrMut repr(transparent)#635Conversation
22638c5 to
fbf073d
Compare
|
Wrote improvised changelog, hope it's done the right way. By the way, after the merge, can you please release a patch version on crates.io? On my workplace, we decided to use this library for some low-level socket operations, and proposed fix would be required (practically speaking, it's not, since transmuting |
fbf073d to
d2678ec
Compare
|
This is ok with me, but I think we usually do not add changelog entries for unreleased changes. |
So, it's OK to simply not add changelog in this PR? |
|
Yes. It will be done in bulk on release. |
Thomasdezeeuw
left a comment
There was a problem hiding this comment.
You can remove the part for the changelog, otherwise LGTM.
…taining `libc::msghdr` from those types
d2678ec to
293f1a9
Compare
Done. |
|
Thanks @nerodono |
Closes #633
This PR simply adds
#[repr(transparent)]to corresponding types, without any methods for conversion on the types themselves.